Opened 5 years ago

Closed 5 years ago

#17011 closed defect (fixed)

fix some old scipy-related weirdness in functions/special.py

Reported by: dimpase Owned by:
Priority: minor Milestone: sage-6.4
Component: numerical Keywords:
Cc: Merged in:
Authors: Dima Pasechnik Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: b690e98 (Commits) Commit: b690e984e8c2fe2ed9ae7ff9b0165a1422416360
Dependencies: Stopgaps:

Description (last modified by dimpase)

In couple of places the conversion from scipy complex number to Sage is done via strings, which is probably some old relic going back to 2008 or so.

As well, the type of the returned number is default Sage's data, rather than C/RDF, as it should be, to avoid confusion about precision of these computations, cf e.g. http://ask.sagemath.org/question/24163/why-does-sage-offer-unusable-scipy

Change History (5)

comment:1 Changed 5 years ago by dimpase

  • Branch set to u/dimpase/fix_some_old_scipy_related_weirdness_in_function_py

comment:2 Changed 5 years ago by dimpase

  • Commit set to b690e984e8c2fe2ed9ae7ff9b0165a1422416360
  • Component changed from PLEASE CHANGE to numerical
  • Description modified (diff)
  • Priority changed from major to minor
  • Summary changed from fix some old scipy-related weirdness in function.py to fix some old scipy-related weirdness in functions/special.py
  • Type changed from PLEASE CHANGE to defect

comment:3 Changed 5 years ago by dimpase

  • Status changed from new to needs_review

comment:4 Changed 5 years ago by vbraun

  • Authors set to Dima Pasechnik
  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

lgtm

comment:5 Changed 5 years ago by vbraun

  • Branch changed from u/dimpase/fix_some_old_scipy_related_weirdness_in_function_py to b690e984e8c2fe2ed9ae7ff9b0165a1422416360
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.