Opened 5 years ago

Closed 5 years ago

#17007 closed enhancement (fixed)

PermutationGroup.minimal_generating_set (from GAP)

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.4
Component: group theory Keywords:
Cc: dimpase Merged in:
Authors: Nathann Cohen Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 4c583ea (Commits) Commit: 4c583ea55e069224f8679dbf9a1b8482fb2e964c
Dependencies: Stopgaps:

Description

Just the boring ol' wrapping.

Nathann

Change History (12)

comment:1 Changed 5 years ago by ncohen

  • Branch set to u/ncohen/17007
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by git

  • Commit set to 7b2f2817ac482a477d436ad98728a09e6faca81a

Branch pushed to git repo; I updated commit sha1. New commits:

7b2f281trac #17007: PermutationGroup.minimal_generating_set (from GAP)

comment:3 follow-up: Changed 5 years ago by dimpase

  • Status changed from needs_review to needs_work

You are not the first to need to convert GAP permutations into Sage ones. There is sage.groups.perm_gps.permgroup.from_gap_list() that does the dirty part, just call it...

(dunno why this function is not exported, perhaps it should be, then it can be easy to find...)

comment:4 Changed 5 years ago by ncohen

Well perhaps, but is miserably fails when the group is not defined over integers.

sage: g=PermutationGroup(["(1,2,3)(4,5,6)","(1,2,3,4,5,6)"])                               
sage: sage.groups.perm_gps.permgroup.from_gap_list(g,str(g._gap_().MinimalGeneratingSet()))
[(2,5)(3,6), (1,5,3,4,2,6)]
sage: g=PermutationGroup([('a','b','c')])                                                  
sage: sage.groups.perm_gps.permgroup.from_gap_list(g,str(g._gap_().MinimalGeneratingSet()))
...
ValueError: Invalid permutation vector:  (1,2,3) 

comment:5 in reply to: ↑ 3 Changed 5 years ago by ncohen

  • Status changed from needs_work to needs_review

Yo !

You are not the first to need to convert GAP permutations into Sage ones. There is sage.groups.perm_gps.permgroup.from_gap_list() that does the dirty part, just call it...

This function was so useful that I overwrote it with my code. Thanks :-P

Nathann

comment:6 Changed 5 years ago by git

  • Commit changed from 7b2f2817ac482a477d436ad98728a09e6faca81a to 44ba55c0c7ad5fcd17aed06c854f865128d68483

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

44ba55ctrac #17007: PermutationGroup.minimal_generating_set (from GAP)

comment:7 Changed 5 years ago by git

  • Commit changed from 44ba55c0c7ad5fcd17aed06c854f865128d68483 to 4c583ea55e069224f8679dbf9a1b8482fb2e964c

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4c583eatrac #17007: PermutationGroup.minimal_generating_set (from GAP)

comment:8 Changed 5 years ago by dimpase

  • Status changed from needs_review to positive_review

LGTM. Hopefully the long tests pass everywhere after this change.

comment:9 Changed 5 years ago by vbraun

  • Status changed from positive_review to needs_work

Reviewer name

comment:10 Changed 5 years ago by ncohen

  • Reviewers set to Dima Pasechnik

comment:11 Changed 5 years ago by dimpase

  • Status changed from needs_work to positive_review

comment:12 Changed 5 years ago by vbraun

  • Branch changed from u/ncohen/17007 to 4c583ea55e069224f8679dbf9a1b8482fb2e964c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.