Opened 5 years ago

Closed 5 years ago

#17005 closed defect (fixed)

to_(di)rected and immutable graphs

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.4
Component: graph theory Keywords:
Cc: tscrim, jmantysalo Merged in:
Authors: Nathann Cohen Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: b316cea (Commits) Commit: b316cea0c951e5150567f2e2b92cd233cac86d1d
Dependencies: Stopgaps:

Description (last modified by ncohen)

sage: Poset({0:[1]})._hasse_diagram.to_undirected()
...
NotImplementedError: An immutable graph does not change name

Change History (10)

comment:1 Changed 5 years ago by ncohen

  • Branch set to u/ncohen/17005
  • Commit set to 0c626799135e2d8a0afcc6661a04c63a102a2c8e
  • Status changed from new to needs_review

New commits:

0c62679trac #17005: to_(di)rected and immutable graphs

comment:2 Changed 5 years ago by ncohen

  • Description modified (diff)

comment:3 Changed 5 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

LGTM modulo rebasing and adding a doctest.

comment:4 Changed 5 years ago by ncohen

Here it is !

Nathann

comment:5 Changed 5 years ago by git

  • Commit changed from 0c626799135e2d8a0afcc6661a04c63a102a2c8e to 105e1e6a991a7aa3f3962804a4c510ab60f4c84b

Branch pushed to git repo; I updated commit sha1. New commits:

105e1e6trac #17005: Merged with latest beta

comment:6 Changed 5 years ago by tscrim

Could you also add a doctest checking that this is fixed? Thanks.

comment:7 Changed 5 years ago by ncohen

OOpppps sorry Travis. I remember having it on my mind then forgot while I was doing the merge.

The weird thing is that this bug seems to be fixed in the latest release. A side effect of #17156 it seems.

Well, I will add the doctest here but it seems that all this patch does is some code cleaning O_o

Nathann

comment:8 Changed 5 years ago by git

  • Commit changed from 105e1e6a991a7aa3f3962804a4c510ab60f4c84b to b316cea0c951e5150567f2e2b92cd233cac86d1d

Branch pushed to git repo; I updated commit sha1. New commits:

b316ceatrac #17005: doctests

comment:9 Changed 5 years ago by tscrim

  • Status changed from needs_review to positive_review

Thanks.

comment:10 Changed 5 years ago by vbraun

  • Branch changed from u/ncohen/17005 to b316cea0c951e5150567f2e2b92cd233cac86d1d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.