Direct Fixdoctests

[vbraun]

Now that we are actually using a versions control system as it is intended, the sage --fixdoctests workflow is a bit antiquated:

• Run sage --fixdoctests src/sage/foo.py
• Get a diff printed to stdout
• copy src/sage/foo.py.out to src/sage/foo.py
• Run git diff to get the same diff again

Instead, just overwrite the file directly. Use version control for the rest.

[vbraun]

New commits:

​8c5f2b0

Directly overwrite with fixed doctests

[jdemeyer]

I would replace sage -git by git since this is supposed to be run from a Sage shell anyway.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​da59f20

call git directly and from the right directory

[jdemeyer]

You also need to fix the documentation (output of ./sage --advanced)

[jdemeyer]

And could you please add a \n to the output file, because otherwise you always get

src/sage/rings/integer.pyx

@@ -6515 +6515 @@
     cdef double d = <double>q64
     if resultsign < 0:
         d = -d
-    return ldexp(d, shift)
+    return ldexp(d, shift)
+ No newline at end of file

(I know you didn't introduce this bug, but it's such a trivial fix...)

[jdemeyer]

Shouldn't

if relative.startswith('.'):

be

if relative.startswith('..'):

(although it seems that relpath strips ./)

[jdemeyer]

There is of course a large margin for improvement in the sage-fixdoctests script (ideally, it should be integrated within the doctesting framework), but if you make the small changes I mentioned, I'm happy with this ticket.

[vbraun]

done

[git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

​e397b3e

Add newline at end of file and fix cmdline help

[git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

​1b99c68

Also fix the cmdline doctest

[vbraun]

Forgot the cmdline test...

[jdemeyer]

Any reason you write

with open(test_file, 'r') as f:
    fixed_test = f.read()

instead of

    fixed_test = open(test_file).read()

[vbraun]

I don't really care either way much, but to me the first version makes it clearer how long the file is actually open for.

[jdemeyer]

lgtm (I was going to set positive_review but apparently you already did that :-p)