Opened 4 years ago
Closed 4 years ago
#16960 closed enhancement (fixed)
Orbit Structure for Affine Morphisms
Reported by:  gjorgenson  Owned by:  

Priority:  minor  Milestone:  sage6.4 
Component:  algebraic geometry  Keywords:  
Cc:  bhutz  Merged in:  
Authors:  Grayson Jorgenson  Reviewers:  Ben Hutz 
Report Upstream:  N/A  Work issues:  
Branch:  f603579 (Commits)  Commit:  f60357916a09ceaf9db164c856fc1d64b773671e 
Dependencies:  Stopgaps: 
Description
Orbit structure is a function for projective morphisms returning the preperiod and period of a point by the map in projective space. The same function can be defined for affine morphisms with little change.
Used the same function code but replaced the examples with those suited for affine space.
sage: A.<x,y,z> = AffineSpace(GF(49, 't'),3) sage: H = Hom(A,A) sage: f = H([x^2  z, x  y + z, y^2  x^2]) sage: f.orbit_structure(A(1,1,2)) [7, 6]
Change History (11)
comment:1 Changed 4 years ago by
 Branch set to u/gjorgenson/ticket/16960
 Created changed from 09/10/14 16:59:51 to 09/10/14 16:59:51
 Modified changed from 09/10/14 16:59:51 to 09/10/14 16:59:51
comment:2 Changed 4 years ago by
 Commit set to 6d95883e26ae482dfc6e85aaf23f05a239cf575b
 Status changed from new to needs_review
comment:3 Changed 4 years ago by
 Reviewers set to Ben Hutz
 Status changed from needs_review to needs_work
Just some minor things. The functionality seems fine. Also put your full name in Author.
function
is spelled wrong in comments. Actually the affine_point version has a number of typos as does the projective_point/projective_morphism versions. This is perhaps a reasonable place to fix all those typos.
comment:4 Changed 4 years ago by
 Commit changed from 6d95883e26ae482dfc6e85aaf23f05a239cf575b to cc902e75aac7348edb0a590833cead156d21dde2
Branch pushed to git repo; I updated commit sha1. New commits:
cc902e7  Typo fixes in the orbit_structure function.

comment:5 Changed 4 years ago by
 Status changed from needs_work to needs_review
comment:6 Changed 4 years ago by
I changed all the typos I could find. Are there any others that should be addressed?
comment:7 Changed 4 years ago by
There are some '=' instead of ' = ' in a couple of the examples.
comment:8 Changed 4 years ago by
 Commit changed from cc902e75aac7348edb0a590833cead156d21dde2 to c92eb7663da8b0d830857ed9a233c36f4bf325c1
Branch pushed to git repo; I updated commit sha1. New commits:
c92eb76  Minor typo fixes in orbit_structure.

comment:9 Changed 4 years ago by
 Branch changed from u/gjorgenson/ticket/16960 to u/bhutz/ticket/16960
 Modified changed from 09/13/14 05:39:41 to 09/13/14 05:39:41
comment:10 Changed 4 years ago by
 Commit changed from c92eb7663da8b0d830857ed9a233c36f4bf325c1 to f60357916a09ceaf9db164c856fc1d64b773671e
 Status changed from needs_review to positive_review
Looks good. I just removed a little bit of trailing white space.
New commits:
f603579  rremoved trailing whitespace

comment:11 Changed 4 years ago by
 Branch changed from u/bhutz/ticket/16960 to f60357916a09ceaf9db164c856fc1d64b773671e
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
Minor addition to affine morhpisms.