Opened 6 years ago

Closed 6 years ago

#16951 closed enhancement (fixed)

Make random_point() for elliptic curves over a finite field uniform

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.4
Component: elliptic curves Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 48bd921 (Commits) Commit: 48bd9210e0fc5ecb7e7188864f047b8fb34cb1a9
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

Currently, 2-torsion points are twice as likely as other points to be "randomly" chosen and the point at infinity is chosen with probability 1/(q+1) regardless of the number of points on E(GF(q)).

Change History (5)

comment:1 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/16951
  • Created changed from 09/09/14 14:46:50 to 09/09/14 14:46:50
  • Modified changed from 09/09/14 15:04:01 to 09/09/14 15:04:01

comment:3 Changed 6 years ago by jdemeyer

  • Commit set to 48bd9210e0fc5ecb7e7188864f047b8fb34cb1a9
  • Status changed from new to needs_review

New commits:

48bd921Choose random points uniformly

comment:4 Changed 6 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

Looks good to me.

comment:5 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/16951 to 48bd9210e0fc5ecb7e7188864f047b8fb34cb1a9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.