Opened 6 years ago
Closed 6 years ago
#16937 closed enhancement (fixed)
Use more mpn functions for bitsets
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.4 |
Component: | misc | Keywords: | |
Cc: | ncohen, dcoudert | Merged in: | |
Authors: | Jeroen Demeyer | Reviewers: | Volker Braun |
Report Upstream: | N/A | Work issues: | |
Branch: | 6872b4a (Commits) | Commit: | 6872b4a06046af286d1271e1e53533dae901814a |
Dependencies: | #16583, #16910, #15946 | Stopgaps: |
Description (last modified by )
In #13352, we use mpn_popcount
for bitsets but more bitset functions could benefit from using MPIR functions.
Change History (9)
comment:1 Changed 6 years ago by
- Description modified (diff)
- Summary changed from Use more mpn functions for bitsets to Use more mpz or mpn functions for bitsets
comment:2 Changed 6 years ago by
- Dependencies set to #16583, #16910, #15946
comment:3 Changed 6 years ago by
- Branch set to u/jdemeyer/ticket/16937
- Created changed from 09/05/14 13:37:06 to 09/05/14 13:37:06
- Modified changed from 09/05/14 14:33:11 to 09/05/14 14:33:11
comment:4 Changed 6 years ago by
- Commit set to 8717825780ec4e2b217b754cc03de2b6a268a86e
- Summary changed from Use more mpz or mpn functions for bitsets to Use more mpn functions for bitsets
comment:5 Changed 6 years ago by
- Commit changed from 8717825780ec4e2b217b754cc03de2b6a268a86e to 6872b4a06046af286d1271e1e53533dae901814a
Branch pushed to git repo; I updated commit sha1. New commits:
6872b4a | Cast size to <int> when comparing
|
comment:6 Changed 6 years ago by
- Modified changed from 09/06/14 05:52:59 to 09/06/14 05:52:59
- Status changed from new to needs_review
comment:7 Changed 6 years ago by
- Cc ncohen dcoudert added
comment:8 Changed 6 years ago by
- Reviewers set to Volker Braun
- Status changed from needs_review to positive_review
comment:9 Changed 6 years ago by
- Branch changed from u/jdemeyer/ticket/16937 to 6872b4a06046af286d1271e1e53533dae901814a
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Last 10 new commits:
Merge with 6.4.beta1
trac #16583, oops, correcting wrong merge
Remove stuff which is not needed
Further cleanup
Fix include of fmpq_poly.pxi in Cython doctest
Get rid of mpz_t_offset hacks
Merge branch 'ticket/16910' into HEAD
Fix mpz_t, mpq_t, mpf_t declarations
Use mpz_srcptr for padics pow_computer
Use mpn functions for bitsets