Opened 8 years ago

Closed 8 years ago

#16933 closed enhancement (fixed)

Remove deprecated code

Reported by: aapitzsch Owned by:
Priority: major Milestone: sage-6.4
Component: misc Keywords: deprecated
Cc: Merged in:
Authors: André Apitzsch Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: cf77bc2 (Commits, GitHub, GitLab) Commit: cf77bc2db234bee09524cdcacb5d8f7777ef6341
Dependencies: Stopgaps:

Status badges

Description

Remove code deprecated in #7983, #13109, #13605, #13192, #14063.

Change History (11)

comment:1 Changed 8 years ago by aapitzsch

Branch: u/aapitzsch/ticket/16933
Commit: 46f4fdc45d81559a40ab2ab13db70644f875582c
Status: newneeds_review

comment:2 Changed 8 years ago by Travis Scrimshaw

I'm pretty sure the stuff in integer_list.py is not deprecated yet as it's still needed.

comment:3 Changed 8 years ago by git

Commit: 46f4fdc45d81559a40ab2ab13db70644f875582cea330d3c88c9a64e504cfb63652856964f79b119

Branch pushed to git repo; I updated commit sha1. New commits:

ea330d3revert remove of iterator() and list()

comment:4 Changed 8 years ago by Jeroen Demeyer

I know I'm being pedantic here...

Explicitly calling Partition._repr_(self, compact=False) hasn't been deprecated so I guess the argument cannot be removed, it should just be totally ignored but not disallowed.

comment:5 Changed 8 years ago by Jeroen Demeyer

And RootSystem(['A',2]).weight_lattice().pi isn't deprecated either...

comment:6 in reply to:  5 ; Changed 8 years ago by aapitzsch

Replying to jdemeyer:

And RootSystem(['A',2]).weight_lattice().pi isn't deprecated either...

According to the comment it somehow is deprecated. But I can revert this change.

Replying to jdemeyer:

Explicitly calling Partition._repr_(self, compact=False) hasn't been deprecated so I guess the argument cannot be removed, it should just be totally ignored but not disallowed.

Do you want me to deprecate the argument?

Last edited 8 years ago by aapitzsch (previous) (diff)

comment:7 in reply to:  6 Changed 8 years ago by Jeroen Demeyer

Replying to aapitzsch:

Replying to jdemeyer:

And RootSystem(['A',2]).weight_lattice().pi isn't deprecated either...

According to the comment it somehow is deprecated. But I can revert this change.

What I meant is that the deprecation warning is commented out in the code for reasons which are not entirely clear to me. I think you should just uncomment that deprecation warning (with ticket number #16933).

Replying to jdemeyer:

Explicitly calling Partition._repr_(self, compact=False) hasn't been deprecated so I guess the argument cannot be removed, it should just be totally ignored but not disallowed.

Do you want me to deprecate the argument?

Perhaps replace the argument with def _repr(self, compact=None): and then you can do in the code

if compact is not None:

comment:8 Changed 8 years ago by aapitzsch

Adding a deprecation warning to pi() leads to several failing doctests because of the @lazy_attribute. Removing @lazy_attribute also doesn't help.

Since there is a warning about the deprecation of pi() in documentation for more than 2 years now (see #6588), we should simply remove pi().

comment:9 Changed 8 years ago by git

Commit: ea330d3c88c9a64e504cfb63652856964f79b119cf77bc2db234bee09524cdcacb5d8f7777ef6341

Branch pushed to git repo; I updated commit sha1. New commits:

2e4f269Merge remote-tracking branch 'origin/develop' into depr_func
cf77bc2deprecate compact argument

comment:10 Changed 8 years ago by Jeroen Demeyer

Reviewers: Jeroen Demeyer
Status: needs_reviewpositive_review

comment:11 Changed 8 years ago by Volker Braun

Branch: u/aapitzsch/ticket/16933cf77bc2db234bee09524cdcacb5d8f7777ef6341
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.