Opened 8 years ago
Closed 8 years ago
#16930 closed enhancement (fixed)
Deprecate non-polynomial modulus argument in constructor of implementations of finite fields
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-6.4 |
Component: | finite rings | Keywords: | |
Cc: | Merged in: | ||
Authors: | Jeroen Demeyer | Reviewers: | Peter Bruin |
Report Upstream: | N/A | Work issues: | |
Branch: | 8cdbd79 (Commits, GitHub, GitLab) | Commit: | 8cdbd7920c73713a3a8dbea697451649f0434f0a |
Dependencies: | #16927, #8373 | Stopgaps: |
Description (last modified by )
The "modulus" parameter for finite fields is handled by the fancy new src/sage/rings/finite_rings/constructor.py
and the implementations of finite fields should only take a polynomial as modulus.
Also improve creating prime finite fields with the non-default implementation.
Change History (9)
comment:1 Changed 8 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 8 years ago by
Status: | new → needs_review |
---|
comment:3 Changed 8 years ago by
Branch: | → u/jdemeyer/ticket/16930 |
---|---|
Created: | Sep 4, 2014, 9:22:49 AM → Sep 4, 2014, 9:22:49 AM |
Modified: | Sep 4, 2014, 11:44:58 AM → Sep 4, 2014, 11:44:58 AM |
comment:4 Changed 8 years ago by
Commit: | → abcf8a6d4042dc08a3d10d494da1df2eba62a592 |
---|
comment:5 Changed 8 years ago by
Status: | needs_review → needs_work |
---|
Doctest failure in elliptic curves...
comment:6 Changed 8 years ago by
Commit: | abcf8a6d4042dc08a3d10d494da1df2eba62a592 → 8cdbd7920c73713a3a8dbea697451649f0434f0a |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
8cdbd79 | Improve computation of j-invariant over smaller field
|
comment:7 Changed 8 years ago by
Status: | needs_work → needs_review |
---|
comment:8 Changed 8 years ago by
Reviewers: | → Peter Bruin |
---|---|
Status: | needs_review → positive_review |
comment:9 Changed 8 years ago by
Branch: | u/jdemeyer/ticket/16930 → 8cdbd7920c73713a3a8dbea697451649f0434f0a |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
Deprecate non-polynomial modulus argument in constructor of implementations of finite fields