Opened 8 years ago

Closed 8 years ago

#16917 closed task (fixed)

Deprecate cuspform_lseries() and modform_lseries()

Reported by: tornaria Owned by:
Priority: major Milestone: sage-6.4
Component: modular forms Keywords:
Cc: Merged in:
Authors: Gonzalo Tornaría Reviewers: Michael Neururer, Nicolás Sirolli
Report Upstream: N/A Work issues:
Branch: 3e5b12f (Commits, GitHub, GitLab) Commit: 3e5b12f5291805d9ee771621cbf117ad7557a07b
Dependencies: #16916, #11631 Stopgaps:

Status badges

Description

From #11631:

the name "cuspform_lseries" is bad, since f is already a cuspform, and we use the name "lseries" in all other places (e.g., elliptic curves, abelian varieties), so it is hard to find. In fact, I didn't even think to look for cuspform_lseries, instead only finding this via lots of grepping and reading source code.

The same applies to "modform_lseries".

The goal of this ticket is to add a method lseries() to modular forms which creates the L-function in both cases, and to deprecate the old two.

Change History (9)

comment:1 Changed 8 years ago by tornaria

  • Authors set to tornaria
  • Branch set to u/tornaria/16917
  • Commit set to 064e2852c41faaf34824732bf14837a28b8fbad8
  • Dependencies set to #16916, #11631
  • Status changed from new to needs_review

I have added a method lseries() to modular forms which creates the L-function in both cases (cuspidal forms and eisenstein series), and deprecated the old two. Part of this is unifying both methods which had very similar code but were staring to diverge.


New commits:

74b6a67Trac #16916: fix precision issues in cuspform_lseries()
ae26b4aTrac #16916: avoid precision issues in cuspform_lseries
13dbf33remove tabs
1939a9cTrac #11631: fix cuspform_lseries() for non-rational newforms
064e285Trac #16917: deprecate cuspform_lseries() and modform_lseries()

comment:2 Changed 8 years ago by mneururer

Review: This works and is a very reasonable change of function names. In many cases the lseries() method leads to a NotImplementedError? (e.g. Eisenstein series not of level 1 or general cusp forms that aren't new forms) but this error is already present in the cuspform_lseries() method.

comment:3 Changed 8 years ago by mneururer

  • Reviewers set to Michael Neururer
  • Status changed from needs_review to positive_review

comment:4 Changed 8 years ago by git

  • Commit changed from 064e2852c41faaf34824732bf14837a28b8fbad8 to 3e5b12f5291805d9ee771621cbf117ad7557a07b
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

3e5b12fTrac #16917: fix a doctest

comment:5 Changed 8 years ago by tornaria

My bad, I forgot to commit a fix for a doctest in src/doc/en/bordeaux_2008/l_series.rst. It is fixed now.

comment:6 Changed 8 years ago by tornaria

  • Authors changed from tornaria to Gonzalo Tornaría

comment:7 Changed 8 years ago by nmsirolli

  • Status changed from needs_review to positive_review

comment:8 Changed 8 years ago by nmsirolli

  • Reviewers changed from Michael Neururer to Michael Neururer, Nicolás Sirolli

comment:9 Changed 8 years ago by vbraun

  • Branch changed from u/tornaria/16917 to 3e5b12f5291805d9ee771621cbf117ad7557a07b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.