Opened 8 years ago

Closed 8 years ago

#16910 closed enhancement (fixed)

Get rid of mpz_t_offset hacks in integer.pyx

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-6.4
Component: cython Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 6fc03e3 (Commits, GitHub, GitLab) Commit: 6fc03e3ea73f1a472b37661ae9ba9a72b4579dcc
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

The comment "Accessing the .value attribute of an Integer object causes Cython to refcount it." is no longer true, so we don't need this hack anymore.

Change History (5)

comment:1 Changed 8 years ago by Jeroen Demeyer

Branch: u/jdemeyer/ticket/16910
Created: Aug 30, 2014, 12:00:41 PMAug 30, 2014, 12:00:41 PM
Modified: Aug 30, 2014, 12:00:41 PMAug 30, 2014, 12:00:41 PM

comment:2 Changed 8 years ago by Jeroen Demeyer

Commit: 6fc03e3ea73f1a472b37661ae9ba9a72b4579dcc
Status: newneeds_review

New commits:

6fc03e3Get rid of mpz_t_offset hacks

comment:3 Changed 8 years ago by Jeroen Demeyer

Description: modified (diff)

comment:4 Changed 8 years ago by Volker Braun

Reviewers: Volker Braun
Status: needs_reviewpositive_review

comment:5 Changed 8 years ago by Volker Braun

Branch: u/jdemeyer/ticket/169106fc03e3ea73f1a472b37661ae9ba9a72b4579dcc
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.