Opened 4 years ago
Closed 4 years ago
#16887 closed enhancement (fixed)
Wider MOLS table plus better interface
Reported by:  ncohen  Owned by:  

Priority:  major  Milestone:  sage6.4 
Component:  combinatorial designs  Keywords:  
Cc:  vdelecroix  Merged in:  
Authors:  Nathann Cohen  Reviewers:  Vincent Delecroix 
Report Upstream:  N/A  Work issues:  
Branch:  35b1643 (Commits)  Commit:  35b1643509a9131fe4b1f95f247dee23371e8b74 
Dependencies:  #16879  Stopgaps: 
Description
With this patch the MOLS table can be printed for values n>1000 with a correct alignment, and you can also pick an interval of values of n you are interested in.
Nathann
Change History (15)
comment:1 Changed 4 years ago by
 Branch set to public/16887
 Status changed from new to needs_review
comment:2 Changed 4 years ago by
 Commit set to b216bda297157ea89b2931d6ce4e283ee7a46f9a
comment:3 Changed 4 years ago by
 Commit changed from b216bda297157ea89b2931d6ce4e283ee7a46f9a to 7c6ce5a711bae158b504640da40f9e439e233109
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
80e0cef  trac #16879: orthogonal_array_recursive.py > pyx

0549110  trac #16879: a is_available function in orthogonal_arrays_recursive

0201bcb  trac #16879: more speed up

b110018  trac #16879: rename orthogonal_arrays_recursive to orthogonal_arrays_find_recursive

d9e0475  trac #16879: Move constructions from orthogonal_arrays_find to orthogonal_arrays_build (this, and only this)

5031aee  trac #16879: Fix the import statements

0c1893f  trac #16879: Fix the doc

6a3869d  trac #16879: speed up

d7129d6  trac #16879: Trivial stuff

7c6ce5a  trac #16887: Wider MOLS table plus better interface

comment:4 Changed 4 years ago by
Hello,
I made the MOLS_table
size adaptative at public/16887b
. What do you think?
Vincent
comment:5 Changed 4 years ago by
 Status changed from needs_review to needs_info
comment:6 Changed 4 years ago by
 Branch changed from public/16887 to public/16887b
 Commit changed from 7c6ce5a711bae158b504640da40f9e439e233109 to 5b71705597d76ab19578a8253963ac9f5562763c
New commits:
5b71705  trac #16887: adaptative MOLS_table

comment:7 Changed 4 years ago by
To me it is being needlessly smart.
Nathann
comment:8 Changed 4 years ago by
 Commit changed from 5b71705597d76ab19578a8253963ac9f5562763c to 111610b98b101da39f972b52c62a4b6ea89b9098
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
111610b  trac #16887: adaptative MOLS_table

comment:9 Changed 4 years ago by
 Status changed from needs_info to positive_review
There was a doctest error... the sage t long
is now fine.
And maybe someday it will be useful to display MOLS_table(10^5)
;)
Vincent
comment:10 followup: ↓ 11 Changed 4 years ago by
 Reviewers set to Vincent Delecroix
For the potential future rebase, it might be better to fold all commits into one because I have just undone all doctest to their previous state. What do you think?
Vincent
comment:11 in reply to: ↑ 10 Changed 4 years ago by
For the potential future rebase, it might be better to fold all commits into one because I have just undone all doctest to their previous state. What do you think?
I don't mind. We update those table frequently anyway.
Really, to me this code is a waste of time. We could have set the width to be 4 for everything, and you go to such lengths to handle absurdly high values (which btw ignore that the screen's width is not infinite).
Anyway. Your code is correct and works, if you don't have anything to change here we can change the ticket's status !
Nathann
comment:12 Changed 4 years ago by
 Commit changed from 111610b98b101da39f972b52c62a4b6ea89b9098 to 35b1643509a9131fe4b1f95f247dee23371e8b74
 Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:
35b1643  trac #16887: adaptative MOLS_table

comment:13 Changed 4 years ago by
 Status changed from needs_review to positive_review
Great! The two commits are now one (you are the author ;) and leads to much less changes.
Vincent
comment:14 Changed 4 years ago by
I don't enjoy much being the "author" of the modifications you made in MOLS_table
. Well, it doesn't matter :P
Nathann
comment:15 Changed 4 years ago by
 Branch changed from public/16887b to 35b1643509a9131fe4b1f95f247dee23371e8b74
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
trac #16879: orthogonal_array_recursive.py > pyx
trac #16879: a is_available function in orthogonal_arrays_recursive
trac #16879: more speed up
trac #16879: rename orthogonal_arrays_recursive to orthogonal_arrays_find_recursive
trac #16879: Move constructions from orthogonal_arrays_find to orthogonal_arrays_build (this, and only this)
trac #16879: Fix the import statements
trac #16879: Fix the doc
trac #16879: speed up
trac #16879: Trivial stuff
trac #16887: Wider MOLS table plus better interface