Opened 5 years ago

Closed 5 years ago

#16863 closed enhancement (fixed)

twin prime difference sets

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-6.4
Component: combinatorial designs Keywords:
Cc: ncohen Merged in:
Authors: Vincent Delecroix Reviewers: Nathann Cohen
Report Upstream: N/A Work issues:
Branch: 5903ac6 (Commits) Commit: 5903ac6fd038c1b81d03133d0fda1421d0827cff
Dependencies: #16802 Stopgaps:

Description

Some new difference set (not very visible... but still new BIBD in perspective).

Change History (6)

comment:1 Changed 5 years ago by vdelecroix

  • Branch set to u/vdelecroix/16863
  • Commit set to 33b4171ada49ca5afa7188dae38b275d37039c6c
  • Status changed from new to needs_review

Last 10 new commits:

b9aa228trac #16722: OA(17,560)
9a57f13trac #16757: Organize the V(m,t) vectors into a dictionary
57c00f0trac #16757: doctest simplication
424e229trac #16763: New OA for n=189, plus some others through Vmt vectors
5ba165etrac #16763: Complete bibliographical references
f3f644dtrac #16763: code simplification
04936aatrac #16802: database of difference family
4bd8d69trac #16802: Review
4434d61trac #16802: review the review
33b4171trac #16863: twin prime difference set

comment:2 Changed 5 years ago by ncohen

Hellloooooooooo !!

Here is a commit (at public/16863) that also handles prime powers (not just primes) as the wikipedia source claims.

What it does:

  • Change the doctests to test all new cases (also a bit faster than the previous doctest)
  • rename fact to factorization
  • Add a reference toward wikipedia
  • Use [x**2 for x in SET] to compute the list of squares.

Your turn !

Nathann

comment:3 Changed 5 years ago by vdelecroix

  • Branch changed from u/vdelecroix/16863 to public/16863
  • Commit changed from 33b4171ada49ca5afa7188dae38b275d37039c6c to 5903ac6fd038c1b81d03133d0fda1421d0827cff

Thanks for the modif!

I changed one sentence in the comments and used a "set version" of the fields in the code (see the last commit).

Needs review again...

Vincent


New commits:

acd60a2trac #16863: Handle all prime powers (not just primes)
5903ac6trac #16863: doc and simplification

comment:4 Changed 5 years ago by ncohen

  • Reviewers set to Nathann Cohen
  • Status changed from needs_review to positive_review

That's all good !

Nathann

comment:5 Changed 5 years ago by vdelecroix

Cool! Thanks!

Vincent

comment:6 Changed 5 years ago by vbraun

  • Branch changed from public/16863 to 5903ac6fd038c1b81d03133d0fda1421d0827cff
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.