Opened 15 years ago

Closed 15 years ago

Last modified 14 years ago

#1685 closed defect (fixed)

[with patch, with causiously positive review] restructuring symmetric functions and misc. combinatorics updates.

Reported by: mhansen Owned by: mhansen
Priority: major Milestone: sage-2.10
Component: combinatorics Keywords:
Cc: sage-combinat Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description


Attachments (4)

1685.patch (244.0 KB) - added by mhansen 15 years ago.
1685-2.patch (86.2 KB) - added by mhansen 15 years ago.
Sage-2.10.alpha2-revert-hunk-from-ticket-1685.patch (1.4 KB) - added by mabshoff 15 years ago.
1685-doctests.patch (840 bytes) - added by mhansen 15 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 15 years ago by mhansen

Status: newassigned

comment:2 Changed 15 years ago by mhansen

The following files need to be deleted:

combinat/sfa.py combinat/kfpoly.py combinat/hall_littlewood.py combinat/hall_polynomial.py

Changed 15 years ago by mhansen

Attachment: 1685.patch added

Changed 15 years ago by mhansen

Attachment: 1685-2.patch added

comment:3 Changed 15 years ago by mhansen

Summary: restructuring symmetric functions and misc. combinatorics updates.[with patch] restructuring symmetric functions and misc. combinatorics updates.

comment:4 Changed 15 years ago by mabshoff

Summary: [with patch] restructuring symmetric functions and misc. combinatorics updates.[with patch, with causiously positive review] restructuring symmetric functions and misc. combinatorics updates.

Hi Mike,

I needed to revert one hunk from the first patch in order to pass doctests. It seems not to belong in the patch logically and calculus.py already has a similar _polynomial_ method. I merged the patch in alpha2, but I am leaving this open for now because I might still have to revert this.

Otherwise I like the patch, it seems to be have plenty of doctests, but I am no expert of the mathematics involved. Let me know what you think.

Cheers,

Michael

comment:5 Changed 15 years ago by mabshoff

Hi Mike,

unfortunately when moving around stuff not all issues get fixed and something assumes the old places of the file or classes. You should be able to fix this much more quickly:

        sage -t  devel/sage-main/sage/libs/symmetrica/schur.pxi
        sage -t  devel/sage-main/sage/libs/symmetrica/sc.pxi
        sage -t  devel/sage-main/sage/libs/symmetrica/kostka.pxi
        sage -t  devel/sage-main/sage/combinat/partition.py
        sage -t  devel/sage-main/sage/combinat/sf/sfa.py
        sage -t  devel/sage-main/sage/combinat/sf/elementary.py
        sage -t  devel/sage-main/sage/combinat/sf/dual.py
        sage -t  devel/sage-main/sage/combinat/sf/hall_littlewood.py
        sage -t  devel/sage-main/sage/combinat/sf/schur.py
        sage -t  devel/sage-main/sage/combinat/sf/monomial.py
        sage -t  devel/sage-main/sage/combinat/sf/homogeneous.py
        sage -t  devel/sage-main/sage/combinat/sf/classical.py
        sage -t  devel/sage-main/sage/combinat/combinatorial_algebra.py
        sage -t  devel/sage-main/sage/combinat/schubert_polynomial.py
        sage -t  devel/sage-main/sage/combinat/tableau.py

Good that I didn't close this ticket yet ;)

Cheers,

Michael

comment:6 Changed 15 years ago by mabshoff

Some of the doctest failures:

sage -t  devel/sage-main/sage/libs/symmetrica/schur.pxi     ****************************************************************
******
File "schur.py", line 341:
    sage: symmetrica.part_part_skewschur([3,2,1],[2,1])
Exception raised:
    Traceback (most recent call last):
      File "/tmp/Work-mabshoff/release-cycle/sage-2.10.alpha3/local/lib/python2.5/doctest.py", line 1212, in __run
        compileflags, 1) in test.globs
      File "<doctest __main__.example_10[0]>", line 1, in <module>
        symmetrica.part_part_skewschur([Integer(3),Integer(2),Integer(1)],[Integer(2),Integer(1)])###line 341:
    sage: symmetrica.part_part_skewschur([3,2,1],[2,1])
      File "schur.pxi", line 131, in sage.libs.symmetrica.symmetrica.part_part_skewschur_symmetrica
        res = _py(cresult)
      File "symmetrica.pxi", line 471, in sage.libs.symmetrica.symmetrica._py
        return _py_schur(a)
      File "symmetrica.pxi", line 768, in sage.libs.symmetrica.symmetrica._py_schur
        s = SymmetricFunctionAlgebra(R, basis='s')
    TypeError: 'NoneType' object is not callable
**********************************************************************
1 items had failures:
   1 of   1 in __main__.example_10
***Test Failed*** 1 failures.

And:

sage -t  devel/sage-main/sage/libs/symmetrica/sc.pxi        Exception exceptions.ImportError: 'No module named sfa' in 'sage
.libs.symmetrica.symmetrica.late_import' ignored

         [1.7 s]
sage -t  devel/sage-main/sage/libs/symmetrica/kostka.pxi    Exception exceptions.ImportError: 'No module named sfa' in 'sage
.libs.symmetrica.symmetrica.late_import' ignored

And:

sage -t  devel/sage-main/sage/combinat/partition.py   
**********************************************************************
File "partition.py", line 1147:
    sage: h( s(part) )
Exception raised:
    Traceback (most recent call last):
      File "/tmp/Work-mabshoff/release-cycle/sage-2.10.alpha3/local/lib/python2.5/doctest.py", line 1212, in __run
        compileflags, 1) in test.globs
      File "<doctest __main__.example_47[4]>", line 1, in <module>
        h( s(part) )###line 1147:
    sage: h( s(part) )
      File "/tmp/Work-mabshoff/release-cycle/sage-2.10.alpha3/local/lib/python2.5/site-packages/sage/combinat/sf/classical.p
y", line 146, in __call__
        xmprime = t( {part:Integer(1)} ).monomial_coefficients()
      File "schur.pxi", line 423, in sage.libs.symmetrica.symmetrica.t_SCHUR_HOMSYM_symmetrica
      File "symmetrica.pxi", line 473, in sage.libs.symmetrica.symmetrica._py
      File "symmetrica.pxi", line 846, in sage.libs.symmetrica.symmetrica._py_homsym
    TypeError: 'NoneType' object is not callable
**********************************************************************
File "partition.py", line 1174:
    sage: Partition([1]).character_polynomial()
Exception raised:
    Traceback (most recent call last):
      File "/tmp/Work-mabshoff/release-cycle/sage-2.10.alpha3/local/lib/python2.5/doctest.py", line 1212, in __run
        compileflags, 1) in test.globs
      File "<doctest __main__.example_48[0]>", line 1, in <module>
        Partition([Integer(1)]).character_polynomial()###line 1174:
    sage: Partition([1]).character_polynomial()
      File "/tmp/Work-mabshoff/release-cycle/sage-2.10.alpha3/local/lib/python2.5/site-packages/sage/combinat/partition.py",
 line 1191, in character_polynomial
        ps_mu = p(s(self))
      File "/tmp/Work-mabshoff/release-cycle/sage-2.10.alpha3/local/lib/python2.5/site-packages/sage/combinat/sf/classical.p
y", line 146, in __call__
        xmprime = t( {part:Integer(1)} ).monomial_coefficients()
      File "schur.pxi", line 464, in sage.libs.symmetrica.symmetrica.t_SCHUR_POWSYM_symmetrica
      File "symmetrica.pxi", line 475, in sage.libs.symmetrica.symmetrica._py
      File "symmetrica.pxi", line 804, in sage.libs.symmetrica.symmetrica._py_powsym
    TypeError: 'NoneType' object is not callable
**********************************************************************

and so on.

         [3.5 s]
sage -t  devel/sage-main/sage/combinat/sf/sfa.py
**********************************************************************
File "sfa.py", line 11:
    : f2 = e(f1)
Exception raised:
    Traceback (most recent call last):
      File "/tmp/Work-mabshoff/release-cycle/sage-2.10.alpha3/local/lib/python2.5/doctest.py", line 1212, in __run
        compileflags, 1) in test.globs
      File "<doctest __main__.example_0[4]>", line 1, in <module>
        f2 = e(f1)###line 11:
    : f2 = e(f1)
      File "/tmp/Work-mabshoff/release-cycle/sage-2.10.alpha3/local/lib/python2.5/site-packages/sage/combinat/sf/classical.p
y", line 146, in __call__
        xmprime = t( {part:Integer(1)} ).monomial_coefficients()
      File "schur.pxi", line 443, in sage.libs.symmetrica.symmetrica.t_SCHUR_ELMSYM_symmetrica
      File "symmetrica.pxi", line 477, in sage.libs.symmetrica.symmetrica._py
      File "symmetrica.pxi", line 825, in sage.libs.symmetrica.symmetrica._py_elmsym
    TypeError: 'NoneType' object is not callable
**********************************************************************

and so on.

sage -t  devel/sage-main/sage/combinat/sf/elementary.py
**********************************************************************
File "elementary.py", line 62:
    sage: a.frobenius()
Exception raised:
    Traceback (most recent call last):
      File "/tmp/Work-mabshoff/release-cycle/sage-2.10.alpha3/local/lib/python2.5/doctest.py", line 1212, in __run
        compileflags, 1) in test.globs
      File "<doctest __main__.example_3[2]>", line 1, in <module>
        a.frobenius()###line 62:
    sage: a.frobenius()
      File "/tmp/Work-mabshoff/release-cycle/sage-2.10.alpha3/local/lib/python2.5/site-packages/sage/combinat/sf/elementary.
py", line 76, in frobenius
        return self.parent()(res)
      File "/tmp/Work-mabshoff/release-cycle/sage-2.10.alpha3/local/lib/python2.5/site-packages/sage/combinat/sf/classical.p
y", line 146, in __call__
        xmprime = t( {part:Integer(1)} ).monomial_coefficients()
      File "schur.pxi", line 788, in sage.libs.symmetrica.symmetrica.t_HOMSYM_ELMSYM_symmetrica
      File "symmetrica.pxi", line 477, in sage.libs.symmetrica.symmetrica._py
      File "symmetrica.pxi", line 825, in sage.libs.symmetrica.symmetrica._py_elmsym
    TypeError: 'NoneType' object is not callable
*********************************************************************

and so on.

Cheers,

Michael

Changed 15 years ago by mhansen

Attachment: 1685-doctests.patch added

comment:7 Changed 15 years ago by mabshoff

Resolution: fixed
Status: assignedclosed

Merged in Sage 2.10.alpha2. I applied 1685-doctests.patch and now all combinatorics doctest pass.

Cheers,

Michael

comment:8 Changed 14 years ago by nthiery

Cc: sage-combinat added
Note: See TracTickets for help on using tickets.