#16847 closed defect (fixed)
LP-related typos
Reported by: | dimpase | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-6.4 |
Component: | linear programming | Keywords: | |
Cc: | ncohen | Merged in: | |
Authors: | Dima Pasechnik | Reviewers: | Nathann Cohen |
Report Upstream: | N/A | Work issues: | |
Branch: | 96bdd0b (Commits) | Commit: | |
Dependencies: | #16714 | Stopgaps: |
Description (last modified by )
few annoying typos fixed
Change History (19)
comment:1 Changed 6 years ago by
- Cc ncohen added
- Component changed from PLEASE CHANGE to linear programming
- Description modified (diff)
- Milestone changed from sage-6.3 to sage-6.4
- Priority changed from major to minor
comment:2 Changed 6 years ago by
- Branch set to public/16847
- Commit set to ed0e3834f75bffa05ba949a0a2c8f856b0836747
comment:3 Changed 6 years ago by
- Dependencies set to 16714
comment:4 follow-up: ↓ 6 Changed 6 years ago by
- Dependencies 16714 deleted
O_o
Is there any way to know which commits correspond to this ticket ? O_o
Nathann
comment:5 Changed 6 years ago by
- Dependencies set to #16714
comment:6 in reply to: ↑ 4 ; follow-up: ↓ 7 Changed 6 years ago by
comment:7 in reply to: ↑ 6 ; follow-up: ↓ 9 Changed 6 years ago by
comment:8 Changed 6 years ago by
- Commit changed from ed0e3834f75bffa05ba949a0a2c8f856b0836747 to 96bdd0b60bac7b9c96d3ff670f7a8496121144e6
Branch pushed to git repo; I updated commit sha1. New commits:
96bdd0b | vi-induced typo in #16847
|
comment:9 in reply to: ↑ 7 ; follow-up: ↓ 11 Changed 6 years ago by
- Status changed from new to needs_review
Replying to ncohen:
the last two in the list above. If you merge it over #16714 you will only see them, I think...
Okay. Really, adding the ticket number to the commit message helps a lot in case like that. Tickets like #16722 would be very hard to review without that
:-P
OK, here is one more commit (with the ticket number). I can in principle fix the other commit messages - should I? Or you can review like this?
comment:10 Changed 6 years ago by
- Type changed from PLEASE CHANGE to defect
comment:11 in reply to: ↑ 9 ; follow-up: ↓ 12 Changed 6 years ago by
Yoooooo !
OK, here is one more commit (with the ticket number). I can in principle fix the other commit messages - should I? Or you can review like this?
Yes yes of course, no problem ! But why did you remove PPL and CVXOPT from this list ? Initially it was not about optional solvers only, was it ?
Nathann
comment:12 in reply to: ↑ 11 Changed 6 years ago by
Replying to ncohen:
Yoooooo !
OK, here is one more commit (with the ticket number). I can in principle fix the other commit messages - should I? Or you can review like this?
Yes yes of course, no problem ! But why did you remove PPL and CVXOPT from this list ? Initially it was not about optional solvers only, was it ?
PPL and CVXOPT are mentioned in the lines just above the one you mean, so it was purely an unnecessary repetition, potentially confusing.
comment:13 Changed 6 years ago by
- Reviewers set to Nathann Cohen
- Status changed from needs_review to positive_review
Oh. Right. Okay, then it's all good. Thanks !
Nathann
comment:14 Changed 6 years ago by
comment:15 follow-up: ↓ 19 Changed 6 years ago by
- Commit changed from 96bdd0b60bac7b9c96d3ff670f7a8496121144e6 to e42ce551e66ff3f854c2424561bc71a075bac67a
- Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
e42ce55 | instanc/tiated...
|
comment:16 Changed 6 years ago by
just saw few more typos... please review the last commit.
comment:17 Changed 6 years ago by
- Status changed from needs_review to positive_review
comment:18 Changed 6 years ago by
- Branch changed from public/16847 to e42ce551e66ff3f854c2424561bc71a075bac67a
- Resolution set to fixed
- Status changed from positive_review to closed
comment:19 in reply to: ↑ 15 Changed 6 years ago by
- Branch changed from e42ce551e66ff3f854c2424561bc71a075bac67a to 96bdd0b60bac7b9c96d3ff670f7a8496121144e6
- Commit e42ce551e66ff3f854c2424561bc71a075bac67a deleted
Replying to git:
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
e42ce55 instanc/tiated...
This last commit has not been merged, see the discussion at sage-devel. I opened a new ticket for that commit: #18219.
Last 10 new commits:
Full doctest coverage
Clean up add_constraint()
Allow specifying constraints via vector-valued linear functions
Also document matrix * MIPVariable notation
Improve documentation
Spelling and docstring fixes
Simplify and document how to extract coefficients
Document generator syntax some more
typo from #16714(comment 59)
more typos in rst docs