Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#16845 closed enhancement (fixed)

Implementation of the Coxeter-Knuth graph in type A

Reported by: aschilling Owned by:
Priority: major Milestone: sage-6.4
Component: combinatorics Keywords: graph, coxeter group, days60
Cc: sage-combinat Merged in:
Authors: Anne Schilling Reviewers: Nicolas M. Thiéry
Report Upstream: N/A Work issues:
Branch: 44e08e3 (Commits) Commit:
Dependencies: Stopgaps:

Description

This branch implements the Coxeter-Knuth graph of type A. The Coxeter-Knuth relations in this case are given by a a+1 a \sim a+1 a a+1, abc \sim acb if b<a<c and abc \sim bac if a<c<b.

Change History (16)

comment:1 Changed 6 years ago by nthiery

  • Keywords days60 added

comment:2 Changed 6 years ago by aschilling

  • Branch set to anne/combinat/16845/coxeter-knuth-graph

comment:3 Changed 6 years ago by aschilling

  • Status changed from new to needs_review

comment:4 Changed 6 years ago by aschilling

  • Branch changed from anne/combinat/16845/coxeter-knuth-graph to u/aschilling/combinat/16845/coxeter-knuth-graph
  • Commit set to 07c6b2a0f6d5ef6410af9b7bc800de9281760975

New commits:

07c6b2aimplementation of the Coxeter-Knuth graph in type A

comment:5 Changed 6 years ago by git

  • Commit changed from 07c6b2a0f6d5ef6410af9b7bc800de9281760975 to 4529af83897c38ed912b03f99757d22597f8d2ad

Branch pushed to git repo; I updated commit sha1. New commits:

4529af8moved code to finite_coxeter_groups and factored out the computation of the neighbors in type A

comment:6 Changed 6 years ago by git

  • Commit changed from 4529af83897c38ed912b03f99757d22597f8d2ad to 4d955dcaec84c00a75173bd110ea0acfb3525a95

Branch pushed to git repo; I updated commit sha1. New commits:

4d955dcchanged according to reviewer

comment:7 Changed 6 years ago by nthiery

  • Status changed from needs_review to positive_review

I checked this with Anne. All good to go!


New commits:

4d955dcchanged according to reviewer

New commits:

4d955dcchanged according to reviewer

comment:8 follow-up: Changed 6 years ago by ncohen

It looks like you import dot2tex for nothing.

Nathann

comment:9 in reply to: ↑ 8 Changed 6 years ago by aschilling

Replying to ncohen:

It looks like you import dot2tex for nothing.

Oh yes! Thanks for catching this! I had latex options in the code, but Nicolas made me remove those and I forgot to remove the import. I will fix this tomorrow (as my internet right now does not allow for shh connections).

comment:10 Changed 6 years ago by vbraun

Reviewer name

comment:11 Changed 6 years ago by vbraun

  • Status changed from positive_review to needs_work

Reviewer name

comment:12 Changed 6 years ago by git

  • Commit changed from 4d955dcaec84c00a75173bd110ea0acfb3525a95 to 44e08e31fb252974e44dc35aa74787da81721cbd

Branch pushed to git repo; I updated commit sha1. New commits:

44e08e3removed superfluous import

comment:13 Changed 6 years ago by aschilling

  • Reviewers set to Nicolas M. Thiery
  • Status changed from needs_work to positive_review

comment:14 Changed 6 years ago by aschilling

I removed the superfluous import and set Nicolas as a reviewer.

comment:15 Changed 6 years ago by vbraun

  • Branch changed from u/aschilling/combinat/16845/coxeter-knuth-graph to 44e08e31fb252974e44dc35aa74787da81721cbd
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:16 Changed 6 years ago by kcrisman

  • Commit 44e08e31fb252974e44dc35aa74787da81721cbd deleted
  • Reviewers changed from Nicolas M. Thiery to Nicolas M. Thiéry
Note: See TracTickets for help on using tickets.