Opened 7 years ago
Closed 6 years ago
#16839 closed enhancement (duplicate)
coordinate vectors for quasi modular forms for hecke triangle groups
Reported by:  jj  Owned by:  

Priority:  minor  Milestone:  sageduplicate/invalid/wontfix 
Component:  modular forms  Keywords:  hecke triangle groups 
Cc:  mraum  Merged in:  
Authors:  Jonas Jermann  Reviewers:  
Report Upstream:  N/A  Work issues:  
Branch:  u/jj/quasi_coords (Commits, GitHub, GitLab)  Commit:  5b5d82307ce1b9a1fd2cb142ffe6063d870a4c35 
Dependencies:  Stopgaps: 
Description (last modified by )
Support for coordinate vectors of quasi modular forms for hecke triangle groups and support for constructing quasi weakly holomorphic forms based on their initial Laurent coefficients. It also adds functions to determine generators and dimensions of certain quasi weak subspaces. This allows to take coordinate vectors of quasi modular forms with respect to the (+ natural) basis of the space. As a consequence also subspaces of quasi modular forms work.
However calculations are usually quite slow/extensive (for both main features).
Additionally the ticket fixes some coercion issues with subspaces, adds corresponding further doctests and corresponding documentation.
Also see Ticket #16883 which depends on this ticket.
Change History (31)
comment:1 Changed 7 years ago by
 Status changed from new to needs_review
comment:2 Changed 7 years ago by
 Commit changed from 9129b947849c5c69ae73530b28eb081017175562 to 418f1c0dd6d4972c320552b2b4d81b4b9ed6fec6
comment:3 Changed 7 years ago by
 Commit changed from 418f1c0dd6d4972c320552b2b4d81b4b9ed6fec6 to f9202ba433c01f62a472a80fe8169e1d6c4bf47c
Branch pushed to git repo; I updated commit sha1. New commits:
f9202ba  marked all tests which took more than 2s as #long time tests

comment:4 Changed 7 years ago by
 Commit changed from f9202ba433c01f62a472a80fe8169e1d6c4bf47c to 195d4d4bd266123bcd32bbc592e5c79393352771
Branch pushed to git repo; I updated commit sha1. New commits:
195d4d4  proper exception handling: for form rings coordinate_vector is not even defined, which is caught by AttributeError

comment:5 Changed 7 years ago by
 Commit changed from 195d4d4bd266123bcd32bbc592e5c79393352771 to 571a8ed091c29fab89784d8843d5db0c410aba77
Branch pushed to git repo; I updated commit sha1. New commits:
571a8ed  proper title for subspaces

comment:6 Changed 7 years ago by
 Commit changed from 571a8ed091c29fab89784d8843d5db0c410aba77 to 0a8bb9cdc81588eb435009a68a2b01f2799ebc58
Branch pushed to git repo; I updated commit sha1. New commits:
0a8bb9c  more consistent documentation if INPUT and OUTPUT

comment:7 Changed 7 years ago by
 Commit changed from 0a8bb9cdc81588eb435009a68a2b01f2799ebc58 to 87acaa659c41225d4b03215ae82e6d85dad6c69f
Branch pushed to git repo; I updated commit sha1. New commits:
87acaa6  added a separate evaluation function, in particular to ensure that its documentation is added to the html documentation

comment:8 Changed 7 years ago by
 Commit changed from 87acaa659c41225d4b03215ae82e6d85dad6c69f to 758e14605487b3ed1aca2813199a15bc87b8c708
Branch pushed to git repo; I updated commit sha1. New commits:
758e146  removed all trailing white spaces

comment:9 Changed 7 years ago by
 Commit changed from 758e14605487b3ed1aca2813199a15bc87b8c708 to c785e231c5e6818123655e47d2f0270b0fc11c38
Branch pushed to git repo; I updated commit sha1. New commits:
c785e23  more documentation fixes

comment:10 Changed 7 years ago by
 Commit changed from c785e231c5e6818123655e47d2f0270b0fc11c38 to 9e8f99f07a8d6d94342a5af132da4d25f66422fa
Branch pushed to git repo; I updated commit sha1. New commits:
9e8f99f  bugfix: the denominator might contain a constant, which we can't just drop

comment:11 Changed 7 years ago by
 Commit changed from 9e8f99f07a8d6d94342a5af132da4d25f66422fa to 8d7c3ecff86369403992d8e87cf51dc61162d6fd
Branch pushed to git repo; I updated commit sha1. New commits:
8d7c3ec  add corresponding doctests for coordinate vectors of vectors with nontrivial denominator

comment:12 Changed 7 years ago by
 Commit changed from 8d7c3ecff86369403992d8e87cf51dc61162d6fd to f7044918207dcd2f9b3666292325aa1ee65a23b9
Branch pushed to git repo; I updated commit sha1. New commits:
f704491  support for constructing quasi weak forms based on their initial Laurent coefficients, support for finding generators/dimensions of quasi weak subspaces corresponding to powers of E2 and to conditions on the order at infinity, unified code for generators and dimensions, support for vector representations of (parts of) laurent series (helper function)

comment:13 Changed 7 years ago by
 Description modified (diff)
comment:14 Changed 7 years ago by
 Commit changed from f7044918207dcd2f9b3666292325aa1ee65a23b9 to c2609a999ec97d53c9e280f5f325bf6b856961df
Branch pushed to git repo; I updated commit sha1. New commits:
c2609a9  bugfix in doctest, use q_expansion_vector in calculations

comment:15 Changed 7 years ago by
 Commit changed from c2609a999ec97d53c9e280f5f325bf6b856961df to 460afe3149ca1dac57bd99b38ee13794e8e5f337
Branch pushed to git repo; I updated commit sha1. New commits:
460afe3  support the same arguments as in q_expansion for q_expansion_vector

comment:16 Changed 7 years ago by
 Status changed from needs_review to needs_work
comment:17 Changed 7 years ago by
 Commit changed from 460afe3149ca1dac57bd99b38ee13794e8e5f337 to 9639621a66a4bdac0a9092a88736d00263e7a433
Branch pushed to git repo; I updated commit sha1. New commits:
9639621  bugfix: It is not enough to take the l1 parameter of the highest weight as an upper bound, it has to be increased by 1 in case the sign change of the multiplier increases l1 by 1

comment:18 Changed 7 years ago by
 Status changed from needs_work to needs_review
comment:19 Changed 7 years ago by
 Commit changed from 9639621a66a4bdac0a9092a88736d00263e7a433 to 5b3bd456c2f8a3cef4f34489e05913d815ef3981
Branch pushed to git repo; I updated commit sha1. New commits:
5b3bd45  Allow elements to return a version of themself where d is replaced by its value (exact in the arithmetic case)

comment:20 Changed 7 years ago by
 Commit changed from 5b3bd456c2f8a3cef4f34489e05913d815ef3981 to f80d76129f1d287531349814e7de7ab99d31ecfc
Branch pushed to git repo; I updated commit sha1. New commits:
f80d761  support for a basis of quasi weak spaces with nice initial Laurent series properties (if possible), in all cases so far the quasi form matrix was invertible, consequently we optimize for that situation, make fix_d a hidden function, updated documentation/tests

comment:21 Changed 7 years ago by
 Commit changed from f80d76129f1d287531349814e7de7ab99d31ecfc to dc0d18a4a48665b5310dd341437e086e1be9e23f
Branch pushed to git repo; I updated commit sha1. New commits:
dc0d18a  use q_basis (if available + cached) to construct quasi forms, clarify that the restriction of min_exp applies to quasi_parts and not linear combinations of them

comment:22 Changed 7 years ago by
 Commit changed from dc0d18a4a48665b5310dd341437e086e1be9e23f to 924e2bde9565855dff2bed769b85b557f85ee1a5
Branch pushed to git repo; I updated commit sha1. New commits:
924e2bd  bugfix: make sure that min_exp is adjusted according to the analytic type to ensure that e.g. q_basis also works properly for holomorphic/cuspidal spaces

comment:23 Changed 7 years ago by
 Commit changed from 924e2bde9565855dff2bed769b85b557f85ee1a5 to 9d407659511f4fb6e3c6f27171059dc09a6e5ff0
Branch pushed to git repo; I updated commit sha1. New commits:
9d40765  A.is_square() is much faster than A.is_invertible()

comment:24 Changed 7 years ago by
 Commit changed from 9d407659511f4fb6e3c6f27171059dc09a6e5ff0 to 2e3b4c246312f7a33d297a6f50c905f5e7138def
Branch pushed to git repo; I updated commit sha1. New commits:
2e3b4c2  bugfix: some normalization issues in MFSeriesConstructor (for functions which are not used at the moment though), support all basic series for the case n=infinity (no implementation for the modular form rings/spaces yet though)

comment:25 Changed 7 years ago by
 Commit changed from 2e3b4c246312f7a33d297a6f50c905f5e7138def to 5b5d82307ce1b9a1fd2cb142ffe6063d870a4c35
Branch pushed to git repo; I updated commit sha1. New commits:
5b5d823  import MFSeriesConstructor by default

comment:26 Changed 7 years ago by
 Component changed from number theory to modular forms
comment:27 Changed 7 years ago by
 Description modified (diff)
comment:28 Changed 7 years ago by
This ticket should be closed as soon as #16883 has been merged, as I have reviewed all changes together.
comment:29 Changed 7 years ago by
 Milestone changed from sage6.4 to sageduplicate/invalid/wontfix
comment:30 Changed 7 years ago by
 Status changed from needs_review to positive_review
comment:31 Changed 6 years ago by
 Resolution set to duplicate
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
performance improvement: remove linearly dependent vectors in one run instead of successively checking each vector