Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#16833 closed enhancement (fixed)

Use MacCauley Resultant to compute resultant of projective morphisms for dim >1

Reported by: jdefaria Owned by: jdefaria
Priority: minor Milestone: sage-6.4
Component: algebraic geometry Keywords:
Cc: bhutz Merged in:
Authors: Joao Alberto de Faria Reviewers: Ben Hutz
Report Upstream: N/A Work issues:
Branch: f9af2f6 (Commits) Commit:
Dependencies: Stopgaps:

Description

Currently resultants for dim greater than one not implemented, changing to call MacCauley? resultants for higher dimensions.

Change History (12)

comment:1 Changed 4 years ago by jdefaria

  • Branch set to u/jdefaria/use_maccauley_resultant_to_compute_resultant_of_projective_morphisms_for_dim__1

comment:2 Changed 4 years ago by jdefaria

  • Authors set to Joao de Faria
  • Branch changed from u/jdefaria/use_maccauley_resultant_to_compute_resultant_of_projective_morphisms_for_dim__1 to u/jdefaria/ticket/16833
  • Commit set to 7529983069d1b07edc8103fca1e6044807d8919f

New commits:

7529983Added functionality for higher dimensional resultants.

comment:3 Changed 4 years ago by git

  • Commit changed from 7529983069d1b07edc8103fca1e6044807d8919f to b3c938087d439bccb2e7672b6c4f6d6ac34cc366

Branch pushed to git repo; I updated commit sha1. New commits:

b3c9380Trac 16833 Added comments and examples

comment:4 Changed 4 years ago by git

  • Commit changed from b3c938087d439bccb2e7672b6c4f6d6ac34cc366 to a019f382d499bd78ee1adddc4532e42d5e1837cf

Branch pushed to git repo; I updated commit sha1. New commits:

a019f38Trac 16833 Fixed typos

comment:5 Changed 4 years ago by jdefaria

  • Status changed from new to needs_review

comment:6 Changed 4 years ago by bhutz

  • Status changed from needs_review to needs_work

A few things here

1) trailing white space at end of function needs to be removed

2) Macaulay is spelled wrong in code comment

3) The function description still describes it as for P1

4) Does macaulay_resulant already coerce to the base ring? so the extra coercsion in that case is not needed. Although we need to be careful since it is saying the output should be in the base_ring of the codomain and macaulay_resultant may coerce to the base ring of the domain.

5) QQbar does not work (but does for macaulay_resultant in general)

Otherwise functionality it working correctly.

comment:7 Changed 4 years ago by git

  • Commit changed from a019f382d499bd78ee1adddc4532e42d5e1837cf to a5385c1d0e839b1e763d9144e18434564d45b319

Branch pushed to git repo; I updated commit sha1. New commits:

a5385c1Fixed problems with coercions from Pari to Sage

comment:8 Changed 4 years ago by git

  • Commit changed from a5385c1d0e839b1e763d9144e18434564d45b319 to a591f72fdfc4be0dca95198bd4b84a26af3cadfc

Branch pushed to git repo; I updated commit sha1. New commits:

a591f72Fixed typos and added an extra error check for domain codomain compatibility

comment:9 Changed 4 years ago by git

  • Commit changed from a591f72fdfc4be0dca95198bd4b84a26af3cadfc to f9af2f6054247577cd551d3c27bd599ebba83c1a

Branch pushed to git repo; I updated commit sha1. New commits:

f9af2f6Changed TypeError to ValueError when passing in wrong fields

comment:10 Changed 4 years ago by bhutz

  • Reviewers set to Ben Hutz
  • Status changed from needs_work to positive_review

This looks good now.

comment:11 Changed 4 years ago by vbraun

  • Branch changed from u/jdefaria/ticket/16833 to f9af2f6054247577cd551d3c27bd599ebba83c1a
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:12 Changed 4 years ago by kcrisman

  • Authors changed from Joao de Faria to Joao Alberto de Faria
  • Commit f9af2f6054247577cd551d3c27bd599ebba83c1a deleted
Note: See TracTickets for help on using tickets.