Opened 4 years ago
Closed 4 years ago
#16832 closed defect (fixed)
Can't coerce projective point to subscheme point
Reported by: | bhutz | Owned by: | bhutz |
---|---|---|---|
Priority: | minor | Milestone: | sage-6.4 |
Component: | algebraic geometry | Keywords: | |
Cc: | Merged in: | ||
Authors: | Peter Bruin | Reviewers: | Ben Hutz |
Report Upstream: | N/A | Work issues: | |
Branch: | f56308d (Commits) | Commit: | f56308daec0bfd46fb863e5f55ec7a0d6f13708c |
Dependencies: | Stopgaps: |
Description
Given a projective point it fails to coerce to a subscheme point if it is created via __call__
. It works for X.point().
sage : P.<x,y,z>= ProjectiveSpace (ZZ ,2) sage : X=P. subscheme (x^2-y^2); sage : X(P([4,4,1]))
Looking in generic/scheme.py, it seems that X.point() should be called with args[0]
instead of args
similarly to what is done for Elliptic Curve points.
Change History (4)
comment:1 Changed 4 years ago by
- Branch set to u/pbruin/16832-scheme_call
- Commit set to f56308daec0bfd46fb863e5f55ec7a0d6f13708c
- Status changed from new to needs_review
comment:2 Changed 4 years ago by
- Status changed from needs_review to positive_review
Thanks for fixing this. You got to it before I had the chance, so I've reviewed it.
Fix looks good and passes all tests.
comment:3 Changed 4 years ago by
- Reviewers set to Ben Hutz
comment:4 Changed 4 years ago by
- Branch changed from u/pbruin/16832-scheme_call to f56308daec0bfd46fb863e5f55ec7a0d6f13708c
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Here is a fix; it also slightly simplifies the
Scheme.__call__()
method.