Opened 8 years ago
Closed 5 years ago
#16825 closed enhancement (fixed)
Implement untwisted affine Lie algebras
Reported by:  tscrim  Owned by:  tscrim 

Priority:  major  Milestone:  sage8.0 
Component:  algebra  Keywords:  lie algebras 
Cc:  bsalisbury1  Merged in:  
Authors:  Travis Scrimshaw  Reviewers:  Ben Salisbury 
Report Upstream:  N/A  Work issues:  
Branch:  3cf54ac (Commits, GitHub, GitLab)  Commit:  3cf54ac6ef970d879e91b9e6c8cea37c25172040 
Dependencies:  #16821  Stopgaps: 
Description
Part of #14901. Implement untwisted affine Lie algebras from their corresponding classical one (given by extending the corresponding current algebra).
Change History (17)
comment:1 Changed 5 years ago by
 Branch set to public/lie_algebras/untwisted_affine16825
 Commit set to 321a6b3ea8761420218e9745a6d3782c44dfbf57
 Milestone changed from sage6.4 to sage8.0
comment:2 Changed 5 years ago by
 Commit changed from 321a6b3ea8761420218e9745a6d3782c44dfbf57 to c75ce5e7e1624590aeee55015fc06c069865a9e0
Branch pushed to git repo; I updated commit sha1. New commits:
c75ce5e  Finishing initial implementation of untwisted affine Lie algebras.

comment:3 Changed 5 years ago by
 Status changed from new to needs_review
comment:4 Changed 5 years ago by
 Commit changed from c75ce5e7e1624590aeee55015fc06c069865a9e0 to a160cfd04aeb57689bf1207653097d71e107d660
Branch pushed to git repo; I updated commit sha1. New commits:
a160cfd  Adding some coercions and exposing some more data.

comment:5 Changed 5 years ago by
 Commit changed from a160cfd04aeb57689bf1207653097d71e107d660 to e2663727b93cdfe35019f76432c4b7ecfcddc530
comment:6 Changed 5 years ago by
 Cc bsalisbury1 added
comment:7 Changed 5 years ago by
 Commit changed from e2663727b93cdfe35019f76432c4b7ecfcddc530 to 394de758ff2e20e31028e0496d920b0e282441d8
comment:8 Changed 5 years ago by
 Commit changed from 394de758ff2e20e31028e0496d920b0e282441d8 to e5a9a3b2e168946ab9011c4d5d7d7d687ab7a758
Branch pushed to git repo; I updated commit sha1. New commits:
9796372  Merge branch 'develop' into t/16825/public/lie_algebras/untwisted_affine16825

0014c81  Merge branch 'public/lie_algebras/untwisted_affine16825' of git://trac.sagemath.org/sage into t/16825/public/lie_algebras/untwisted_affine16825

76f940f  Merge branch 'develop' into t/16825/public/lie_algebras/untwisted_affine16825

f308868  Changed naming conventions in the documentation introduction

e5a9a3b  Changed delta to d and Lie derivative to canonical derivation

comment:9 Changed 5 years ago by
It's not working currently, but I'm hoping you can help. The current complaint I'm getting is
'sage.algebras.lie_algebras.lie_algebra_element.UntwistedAffineLieAlgebraElement' object has no attribute '_d_coeff'
This comes, for example, when trying to compute
sage: g = LieAlgebra(QQ, cartan_type=['A',1,1]) sage: list(g.lie_algebra_generators())
I went to the .pyx
file and confirmed that the attribute _d_coeff
is there, so I'm not sure what's going wrong.
comment:10 Changed 5 years ago by
You need to change cdef _delta_coeff
in the pxd
file to cdef _d_coeff
.
comment:11 Changed 5 years ago by
 Commit changed from e5a9a3b2e168946ab9011c4d5d7d7d687ab7a758 to cbf09d3d3dc5e07c06b275610eb7334b6bf7e7ba
Branch pushed to git repo; I updated commit sha1. New commits:
cbf09d3  Fixed typo in pxd file

comment:12 Changed 5 years ago by
 Reviewers set to Ben Salisbury
Hi Travis,
I made a bunch of changes. If you are okay with them, then you may set this to positive review. All documentation builds and tests passed on my machine.
Ben
comment:13 Changed 5 years ago by
 Status changed from needs_review to positive_review
Looks good. Thank you!
comment:14 Changed 5 years ago by
 Status changed from positive_review to needs_work
sage t long src/sage/algebras/lie_algebras/lie_algebra_element.pyx ********************************************************************** File "src/sage/algebras/lie_algebras/lie_algebra_element.pyx", line 774, in sage.algebras.lie_algebras.lie_algebra_element.UntwistedAffineLieAlgebraElement.__hash__ Failed example: hash(x) Expected: 1782435762440299943 Got: 684399193 ********************************************************************** 1 item had failures: 1 of 5 in sage.algebras.lie_algebras.lie_algebra_element.UntwistedAffineLieAlgebraElement.__hash__ [202 tests, 1 failure, 1.05 s]
comment:15 Changed 5 years ago by
 Commit changed from cbf09d3d3dc5e07c06b275610eb7334b6bf7e7ba to 3cf54ac6ef970d879e91b9e6c8cea37c25172040
Branch pushed to git repo; I updated commit sha1. New commits:
3cf54ac  Better hash test.

comment:16 Changed 5 years ago by
 Status changed from needs_work to positive_review
32bit/64bit hash failure. Fixed.
comment:17 Changed 5 years ago by
 Branch changed from public/lie_algebras/untwisted_affine16825 to 3cf54ac6ef970d879e91b9e6c8cea37c25172040
 Resolution set to fixed
 Status changed from positive_review to closed
Preliminary version.
Last 10 new commits:
Adding back support for creating a Lie algebra from a Cartan type.
Fixing bugs in structure coefficients of Chevalley basis.
Implementing matrix Lie algebras in types E6, F4, and G2.
Merge branch 't/16820/public/lie_algebras/fd_structure_coeff16820' into t/16821/public/lie_algebras/classical16821
Fix citation problem
Merge branch 'public/lie_algebras/classical16821' of git://trac.sagemath.org/sage into public/lie_algebras/classical16821
Doing rebasing due to changes in base ticket.
Merge branch 'develop' into public/lie_algebras/classical16821
New data structure for elements.
Adding affine method and fixing highest root element for matrix Lie algebras.