Opened 8 years ago

Closed 5 years ago

#16822 closed enhancement (fixed)

Implement PBW bases for the universal enveloping algebra

Reported by: tscrim Owned by: tscrim
Priority: major Milestone: sage-8.0
Component: algebra Keywords: lie algebras, days64
Cc: bsalisbury1 Merged in:
Authors: Travis Scrimshaw Reviewers: Ben Salisbury
Report Upstream: N/A Work issues:
Branch: 394083b (Commits, GitHub, GitLab) Commit: 394083b21791cc865493924de3de9ab0c6ff41d6
Dependencies: #16820 Stopgaps:

Status badges

Description

Part of #14901. Implements the PBW basis for a Lie algebra with computable structure coefficients.

Change History (17)

comment:1 Changed 7 years ago by tscrim

  • Branch set to public/lie_algebras/PBW_basis-16822
  • Commit set to acf7a815a41916caf9a08c0c533470e7bb940c9b
  • Dependencies changed from #16819 #16820 to #16820
  • Status changed from new to needs_review

Last 10 new commits:

​980545eFixed the doc.
​8a6950aMerge branch 'public/categories/lie_algebras-16819' of git://trac.sagemath.org/sage into lie1
​9b08311a few questions to boot
​5a0bc7dAnswering some questions.
​144a5a5Small fix for the doc.
​198f8a8Added new categories to documentation.
​aeb6075Merge branch 'public/categories/lie_algebras-16819' into public/lie_algebras/fd_structure_coeff-16820
​ece3cd9Added files to the documentation.
​05dab33Merge branch 'public/lie_algebras/fd_structure_coeff-16820' into public/lie_algebras/PBW_basis-16822
​acf7a81Added PBW basis for Lie algebras.

comment:2 Changed 7 years ago by git

  • Commit changed from acf7a815a41916caf9a08c0c533470e7bb940c9b to 4c38c0154869dd9cbe8bf0ca647dec891f60fee1

Branch pushed to git repo; I updated commit sha1. New commits:

​4c38c01Added example for pbw_basis() method.

comment:3 Changed 7 years ago by git

  • Commit changed from 4c38c0154869dd9cbe8bf0ca647dec891f60fee1 to b5cae2110f0087299638f519fedbcf02d6f29286

Branch pushed to git repo; I updated commit sha1. New commits:

​4343505Merge branch 'develop' into public/lie_algebras/PBW_basis-16822
​5197c7cMerge branch 'develop' into public/lie_algebras/fd_structure_coeff-16820
​845e5aaSome last tweaks and getting full coverage.
​b5cae21Merge branch 'public/lie_algebras/fd_structure_coeff-16820' into public/lie_algebras/PBW_basis-16822

comment:4 Changed 7 years ago by tscrim

  • Keywords days64 added
  • Milestone changed from sage-6.4 to sage-6.6

comment:5 Changed 7 years ago by git

  • Commit changed from b5cae2110f0087299638f519fedbcf02d6f29286 to d754f667d0c271c9accdc1760a7ffe0dc5393fcf

Branch pushed to git repo; I updated commit sha1. New commits:

​d754f66fixed merge conflict

comment:6 Changed 7 years ago by kdilks

  • Milestone changed from sage-6.6 to sage-6.10

New commits:

​d754f66fixed merge conflict

comment:7 Changed 6 years ago by git

  • Commit changed from d754f667d0c271c9accdc1760a7ffe0dc5393fcf to 374e7860663507d8f6d787b88a15ca1fb6662b5d

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

​6815f1creview heisenberg.py again; coercion still relies on unstaged changes to module morphisms
​573e074Merge branch 'public/lie_algebras/fd_structure_coeff-16820' of trac.sagemath.org:sage into public/lie_algebras/fd_structure_coeff-16820
​3f9a4a1Fixing the failing doctests and making the doc build.
​b9930e6some changes to standardization of names
​60f743aParsing the input so that it uses the indexing set.
​a02380fMerge branch 'public/lie_algebras/fd_structure_coeff-16820' in 7.0.rc1
​50f4441trac #16820 correct the spelling of Cartesian
​f1514bdMerge branch 'public/lie_algebras/fd_structure_coeff-16820' into 7.3.b2
​7d155ecFixing trivial doctest failures.
​374e786Merge branch 'public/lie_algebras/PBW_basis-16822' of trac.sagemath.org:sage into public/lie_algebras/PBW_basis-16822

comment:8 Changed 5 years ago by git

  • Commit changed from 374e7860663507d8f6d787b88a15ca1fb6662b5d to 49cf8eecfecd2f2180d90480e351fe18f7cfe386

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

​965c70btrac 16820 no more xrange
​e8c5256Merge branch 'public/lie_algebras/fd_structure_coeff-16820' in 7.5.rc1
​7c92fd1trac 16820 nonzero -> bool
​a9d636cMerge branch 'public/lie_algebras/fd_structure_coeff-16820' in 7.6.b5
​7bda1a4trac 16820 get rid of some .iteritems in py files
​3e2c547Merge branch 'public/lie_algebras/fd_structure_coeff-16820' of git://trac.sagemath.org/sage into public/lie_algebras/fd_structure_coeff-16820
​cf88feeChanges for the reviewer and using standard copyright.
​42666d4Adding centralizer_basis method, improving to/from_vector for finite-dim Lie algebras, other fixes.
​59df7ceFixing pdf docbuild in finite-dim Lie algebras w/ basis category.
​49cf8eeMerge branch 'public/lie_algebras/PBW_basis-16822' of git://trac.sagemath.org/sage into public/lie_algebras/PBW_basis-16822

comment:9 Changed 5 years ago by tscrim

  • Milestone changed from sage-6.10 to sage-8.0

comment:10 Changed 5 years ago by git

  • Commit changed from 49cf8eecfecd2f2180d90480e351fe18f7cfe386 to ed96e1d8e577ccde243d7108ba22610c1ca1f020

Branch pushed to git repo; I updated commit sha1. New commits:

​ed587afImplementing ideal checks and fixing product_space.
​3baf33fMerge branch 'develop' into public/lie_algebras/fd_structure_coeff-16820
​c0f01dfCache is_ideal and explaining doc what is clear from the code.
​fc395c8Fixing typo.
​64ab605Trivial fix by making docstring a raw string.
​299a0b4Merge branch 'public/lie_algebras/PBW_basis-16822' of git://trac.sagemath.org/sage into public/lie_algebras/PBW_basis-16822
​ed96e1dRemoving cmp in PBW bases.

comment:11 Changed 5 years ago by bsalisbury1

  • Cc bsalisbury1 added

comment:12 Changed 5 years ago by bsalisbury1

  • Reviewers set to Ben Salisbury
  • Status changed from needs_review to needs_work 
----------------------------------------------------------------------
sage -t src/sage/algebras/lie_algebras/poincare_birkhoff_witt.py  # 27 doctests failed
----------------------------------------------------------------------
Last edited 5 years ago by bsalisbury1 (previous) (diff)

comment:13 Changed 5 years ago by git

  • Commit changed from ed96e1d8e577ccde243d7108ba22610c1ca1f020 to 66ce4a03b7b7a1905caac4a375387cbb6ae20a37

Branch pushed to git repo; I updated commit sha1. New commits:

​3dca78bMerge branch 'develop' into t/16822/public/lie_algebras/PBW_basis-16822
​66ce4a0Corrected documentation errors

comment:14 Changed 5 years ago by git

  • Commit changed from 66ce4a03b7b7a1905caac4a375387cbb6ae20a37 to 394083b21791cc865493924de3de9ab0c6ff41d6

Branch pushed to git repo; I updated commit sha1. New commits:

​394083bFixing failures in PBW algebras.

comment:15 Changed 5 years ago by tscrim

  • Status changed from needs_work to needs_review

Most of those came from the change of what sl2 means. It also showed an inconsistency with the index set of the classical Lie algebras not being a FiniteEnumeratedSet (well, really something having a cardinality).

comment:16 Changed 5 years ago by bsalisbury1

  • Status changed from needs_review to positive_review

Math looks good, documentation looks good, all tests passed on my machine, and all documentation builds.

comment:17 Changed 5 years ago by vbraun

  • Branch changed from public/lie_algebras/PBW_basis-16822 to 394083b21791cc865493924de3de9ab0c6ff41d6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.