Changes between Initial Version and Version 1 of Ticket #16820, comment 25
 Timestamp:
 04/16/15 19:56:50 (7 years ago)
Legend:
 Unmodified
 Added
 Removed
 Modified

Ticket #16820, comment 25
initial v1 23 23 > For the `FromAssociative.lift`...well there's some ambiguity there as to whether we want to lift to the UEA or just some enveloping algebra. I opted to lift just to the defining algebra (which I forgot to change in the docs) as this seemed the most natural. We will also have to deal with subalgebras and a `lift` there. 24 24 25 I am in favor of renaming it then. The abstract `lift` lazy_attribute in `sage/categories/lie_algebras.py` explicitly speaks of the UEA in its doc. 25 I am in favor of renaming it then. The abstract `lift` lazy_attribute in `sage/categories/lie_algebras.py` explicitly speaks of the UEA in its doc. A `lift` that can go anywhere depending on the concrete algebra will be rather useless. 26 26 27 27 > For the tested methods, it was originally returning an element from a matrix Lie algebra, but through refactoring this had changed. This can be remedied by changing the 3 to 1, i.e.: `L = lie_algebras.three_dimensional_by_rank(QQ, 1)`. 28 > 28 29 Thanks, will do. (But will also need to move the current doctests somewhere.) 30 29 31 > I'm also not happy with the corner cases being allowed as all properties become vacuous. 30 32 31 33 The corner cases need to be allowed, and I've already caught at least 2 bugs by inserting tests for them. 32 33 New commits:34 [http://git.sagemath.org/sage.git/commit/?id=8c5361b202dd68b31be6eb414b437badceb3fa76 8c5361b]{{{meanwhile, fix _acted_upon_ bug}}}