Opened 6 years ago

Closed 6 years ago

#16805 closed enhancement (fixed)

Putting some include paths in common

Reported by: Snark Owned by:
Priority: minor Milestone: sage-6.4
Component: build Keywords:
Cc: Merged in:
Authors: Julien Puydt Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 77076e1 (Commits) Commit: 77076e1e3e7c2b5596f9cbee9040d87f49b3b205
Dependencies: Stopgaps:

Description

I'm proposing the following patch to remove duplication in the src/module_list.py file.

Attachments (1)

singular_incs.patch (5.6 KB) - added by Snark 6 years ago.

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by Snark

comment:1 Changed 6 years ago by Snark

  • Status changed from new to needs_review

comment:2 Changed 6 years ago by vbraun

How about you post a git branch? ;-)

comment:3 Changed 6 years ago by Snark

  • Authors set to Julien Puydt

Back in the days, trivial patches for sage needed to be committed in a mercurial tree packed in a compressed tarball attached to a ticket.

I'm not used to the new organization.

comment:5 Changed 6 years ago by Snark

  • Branch set to u/Snark/putting_some_include_paths_in_common

comment:6 Changed 6 years ago by vbraun

  • Commit set to 77076e1e3e7c2b5596f9cbee9040d87f49b3b205
  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

lgtm


New commits:

77076e1Put singular includes in a common variable in src/module_list.py

comment:7 Changed 6 years ago by vbraun

  • Branch changed from u/Snark/putting_some_include_paths_in_common to 77076e1e3e7c2b5596f9cbee9040d87f49b3b205
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.