Opened 7 years ago

Closed 7 years ago

#16794 closed defect (fixed)

Circular dependencies: patch : bzip2 : pkgconf

Reported by: vbraun Owned by:
Priority: blocker Milestone: sage-6.4
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Volker Braun Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: e66c236 (Commits, GitHub, GitLab) Commit: e66c236347131cf8e0489f4cd16c2f0fbe948af3
Dependencies: Stopgaps:

Status badges

Description (last modified by vbraun)

This usually doesn't surface since pretty much everybody has patch installed already, but:

  • patch requires bzip2
  • bzip2 requires pkgconf
  • pkgconf uses patch to apply a patch (currently this dependency is not known to the Sage build system in build/deps)

Patch gzip tarball: ftp://ftp.gnu.org/gnu/patch/patch-2.7.1.tar.gz

Change History (16)

comment:1 Changed 7 years ago by vbraun

The solution seems to be to distribute patch as gzipped tarball (not: bzip2) and remove this dependency, and add the dependency of pkgconf on patch instead.

comment:2 Changed 7 years ago by vbraun

  • Description modified (diff)

comment:3 Changed 7 years ago by vbraun

  • Description modified (diff)

comment:4 Changed 7 years ago by vbraun

  • Branch set to u/vbraun/circular_dependencies

comment:5 Changed 7 years ago by vbraun

  • Authors set to Volker Braun
  • Commit set to 7883bdc822e8a8704cf9629f4326567ee838d471
  • Status changed from new to needs_review

New commits:

36b2ab6update to patch 2.7.1
7883bdcfix dependencies

comment:6 Changed 7 years ago by git

  • Commit changed from 7883bdc822e8a8704cf9629f4326567ee838d471 to e38b2d387016ea7d8381d9043349001cf26da8b4

Branch pushed to git repo; I updated commit sha1. New commits:

e38b2d3Convert pyparsing patch to unix line endings

comment:7 Changed 7 years ago by git

  • Commit changed from e38b2d387016ea7d8381d9043349001cf26da8b4 to e66c236347131cf8e0489f4cd16c2f0fbe948af3

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e66c236Apply pyparsing patch in binary mode

comment:8 Changed 7 years ago by vbraun

The pyparsing sources have DOS line endings, ughh..

comment:9 Changed 7 years ago by vbraun

  • Priority changed from major to blocker

comment:10 Changed 7 years ago by jhpalmieri

Should bzip2 even be a package anymore? I always thought that we included it for compressing and decompressing .spkg files. Now with the new packaging system (although there are some old-style optional and experimental packages still), not to mention the fact that bzip2 is pretty standard, can we just get rid of it?

comment:11 Changed 7 years ago by vbraun

There are still bzip2-compressed tarballs. We can certainly discuss adding it as a host dependency on another ticket...

comment:12 Changed 7 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer

comment:13 Changed 7 years ago by jdemeyer

What's the reason for upgrading patch? Have you tested this well on the buildbots? I remember lots of portability trouble with patch-2.6.x, that's the reason why we never upgraded before.

The changes to build/deps look good to me.

comment:14 Changed 7 years ago by vbraun

I haven't tried, but I will anyway when merging the ticket. It seems a bit redundant to do it twice.

Since we don't have a solaris buildbot any more its probably fine. I upgraded patch since I think there will be problem with the build system if tarballs only differ by extension, haven't tried to find out exactly what might break though.

comment:15 Changed 7 years ago by jdemeyer

  • Status changed from needs_review to positive_review

OK, I'm giving it the benefit of the doubt...

comment:16 Changed 7 years ago by vbraun

  • Branch changed from u/vbraun/circular_dependencies to e66c236347131cf8e0489f4cd16c2f0fbe948af3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.