Opened 5 years ago

Closed 5 years ago

#16789 closed defect (fixed)

Combinatorial designs use internet during doctest

Reported by: vbraun Owned by:
Priority: blocker Milestone: sage-6.3
Component: combinatorial designs Keywords:
Cc: ncohen Merged in:
Authors: Volker Braun Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 54f71de (Commits) Commit: 54f71de05c76dcc7a5948c5d7be6095a61f8ce61
Dependencies: Stopgaps:

Description

Doctests that use internet must be marked # optional - internet

sage -t --long src/sage/combinat/designs/bibd.py
**********************************************************************
File "src/sage/combinat/designs/bibd.py", line 114, in sage.combinat.designs.bibd.balanced_incomplete_block_design
Failed example:
    designs.balanced_incomplete_block_design(66,6, use_LJCR=True)
Exception raised:
    Traceback (most recent call last):
      File "/var/tmp/tmp95hfLr/sage-6.3/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 480, in _run
        self.execute(example, compiled, test.globs)
      File "/var/tmp/tmp95hfLr/sage-6.3/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 839, in execute
        exec compiled in globs
      File "<doctest sage.combinat.designs.bibd.balanced_incomplete_block_design[1]>", line 1, in <module>
        designs.balanced_incomplete_block_design(Integer(66),Integer(6), use_LJCR=True)
      File "/var/tmp/tmp95hfLr/sage-6.3/local/lib/python2.7/site-packages/sage/combinat/designs/bibd.py", line 225, in balanced_incomplete_block_design
        B = best_known_covering_design_www(v,k,2)
      File "/var/tmp/tmp95hfLr/sage-6.3/local/lib/python2.7/site-packages/sage/combinat/designs/covering_design.py", line 498, in best_known_covering_design_www
        f = urllib.urlopen(url)
      File "/var/tmp/tmp95hfLr/sage-6.3/local/lib/python/urllib.py", line 87, in urlopen
        return opener.open(url)
      File "/var/tmp/tmp95hfLr/sage-6.3/local/lib/python/urllib.py", line 208, in open
        return getattr(self, name)(url)
      File "/var/tmp/tmp95hfLr/sage-6.3/local/lib/python/urllib.py", line 345, in open_http
        h.endheaders(data)
      File "/var/tmp/tmp95hfLr/sage-6.3/local/lib/python/httplib.py", line 991, in endheaders
        self._send_output(message_body)
      File "/var/tmp/tmp95hfLr/sage-6.3/local/lib/python/httplib.py", line 844, in _send_output
        self.send(msg)
      File "/var/tmp/tmp95hfLr/sage-6.3/local/lib/python/httplib.py", line 806, in send
        self.connect()
      File "/var/tmp/tmp95hfLr/sage-6.3/local/lib/python/httplib.py", line 787, in connect
        self.timeout, self.source_address)
      File "/var/tmp/tmp95hfLr/sage-6.3/local/lib/python/socket.py", line 573, in create_connection
        raise err
    IOError: [Errno socket error] [Errno 110] Connection timed out
**********************************************************************
1 item had failures:
   1 of  15 in sage.combinat.designs.bibd.balanced_incomplete_block_design
    [74 tests, 1 failure, 133.52 s]

Change History (4)

comment:1 Changed 5 years ago by vbraun

  • Branch set to u/vbraun/combinatorial_designs_use_internet_during_doctest

comment:2 Changed 5 years ago by vbraun

  • Authors set to Volker Braun
  • Commit set to 54f71de05c76dcc7a5948c5d7be6095a61f8ce61
  • Status changed from new to needs_review

New commits:

54f71demark all internet-using doctests as

comment:3 Changed 5 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to positive_review

Hi Volker,

Seems to be introduced in #16614... Thanks!

Vincent

comment:4 Changed 5 years ago by vbraun

  • Branch changed from u/vbraun/combinatorial_designs_use_internet_during_doctest to 54f71de05c76dcc7a5948c5d7be6095a61f8ce61
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.