Opened 5 years ago
Closed 5 years ago
#16787 closed enhancement (fixed)
Implement construction of finite state machine by copying another machine
Reported by:  cheuberg  Owned by:  

Priority:  minor  Milestone:  sage6.4 
Component:  finite state machines  Keywords:  copy, initialization 
Cc:  dkrenn, skropf  Merged in:  
Authors:  Clemens Heuberger  Reviewers:  Daniel Krenn 
Report Upstream:  N/A  Work issues:  
Branch:  90e60b5 (Commits)  Commit:  90e60b579aa73cf488a6f4cb7778b784736a89f5 
Dependencies:  #16786  Stopgaps: 
Description (last modified by )
sage: F = FiniteStateMachine() sage: FiniteStateMachine(F)
led to a NotImplementedError
.
This is now implemented.
Depends on #16786 as the documentation refers to the attributes input_alphabet
, output_alphabet
.
Change History (10)
comment:1 Changed 5 years ago by
 Status changed from new to needs_review
comment:2 Changed 5 years ago by
 Milestone changed from sage6.3 to sage6.4
comment:3 Changed 5 years ago by
 Branch changed from u/cheuberg/fsm/copyfromother to u/dkrenn/fsm/copyfromother
comment:4 Changed 5 years ago by
 Commit changed from 0b554637f2d1b9663d65b3730c7f3cd208a7f545 to 04fdac4ff93676d58a6c3ec4197527fb73598676
 Reviewers set to Daniel Krenn
comment:5 Changed 5 years ago by
 Branch changed from u/dkrenn/fsm/copyfromother to u/cheuberg/fsm/copyfromother
comment:6 Changed 5 years ago by
 Commit changed from 04fdac4ff93676d58a6c3ec4197527fb73598676 to 90e60b579aa73cf488a6f4cb7778b784736a89f5
Branch pushed to git repo; I updated commit sha1. New commits:
90e60b5  Merge branch 'develop' into fsm/copyfromother

comment:7 Changed 5 years ago by
comment:8 Changed 5 years ago by
 Status changed from needs_review to positive_review
comment:9 Changed 5 years ago by
 Description modified (diff)
comment:10 Changed 5 years ago by
 Branch changed from u/cheuberg/fsm/copyfromother to 90e60b579aa73cf488a6f4cb7778b784736a89f5
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
I've moved the tests with wrong input to the test section. Apart from this, everything looks good, doctests pass and so on. Positive for me; feel free to set it to positive_review after crossreviewing my changes.
New commits:
moved tests to TESTsection of docstring