Opened 7 years ago

Closed 7 years ago

#16786 closed enhancement (fixed)

FiniteStateMachine: document attributes input_alphabet, output_alphabet

Reported by: cheuberg Owned by:
Priority: trivial Milestone: sage-6.4
Component: finite state machines Keywords: documentation, input_alphabet, output_alphabet
Cc: skropf, dkrenn Merged in:
Authors: Clemens Heuberger Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: e403fd3 (Commits, GitHub, GitLab) Commit: e403fd3ff1e7cae48c61cd301a5567e877afb964
Dependencies: Stopgaps:

Status badges

Description (last modified by cheuberg)

The attributes input_alphabet, output_alphabet shall be documented and included in the TOC of the documentation of the module finite_state_machine.

Also a rewording of the documentation of on_duplicate_transition.

Also included hyperlinks to DiGraph where appropriate.

Change History (7)

comment:1 Changed 7 years ago by cheuberg

  • Status changed from new to needs_review

comment:2 Changed 7 years ago by git

  • Commit changed from 5af28016be04e8f4b814a7f46bd4124e9335441c to 83b8122f46dc58b6d89e74ec739fb596601986c2

Branch pushed to git repo; I updated commit sha1. New commits:

83b8122Insert hyperlinks to DiGraph where appropriate.

comment:3 Changed 7 years ago by cheuberg

  • Description modified (diff)

comment:4 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:5 Changed 7 years ago by dkrenn

  • Branch changed from u/cheuberg/fsm/docs-improved-3 to u/dkrenn/fsm/docs-improved-3

comment:6 Changed 7 years ago by dkrenn

  • Commit changed from 83b8122f46dc58b6d89e74ec739fb596601986c2 to e403fd3ff1e7cae48c61cd301a5567e877afb964
  • Reviewers set to Daniel Krenn
  • Status changed from needs_review to positive_review

Patch is fine, positive for me. Added two additional links in the seealso sections.

New commits:

e403fd3seealso: input-/output-alphabet crosslinked

comment:7 Changed 7 years ago by vbraun

  • Branch changed from u/dkrenn/fsm/docs-improved-3 to e403fd3ff1e7cae48c61cd301a5567e877afb964
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.