Opened 6 years ago

Closed 6 years ago

#16784 closed defect (fixed)

Allow ctrl-C to interrupt incomplete multiline Sage command

Reported by: jhpalmieri Owned by:
Priority: minor Milestone: sage-6.4
Component: misc Keywords:
Cc: vbraun, saliola Merged in:
Authors: Volker Braun Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: bbaf964 (Commits) Commit: bbaf9644f2b854e6b45a0177180705fc32d63c81
Dependencies: Stopgaps:

Description

Since Sage 5.11.rc0, hitting ctrl-c after this

sage: print('hello'
....: 

does not return to the Sage prompt, it just says

KeyboardInterrupt
....: 

Hitting ctrl-c should instead return you to the prompt, as it used to do.

My guess is that this comes from #14523.

Change History (7)

comment:1 Changed 6 years ago by vbraun

true, sounds plausible.

comment:2 Changed 6 years ago by saliola

  • Cc saliola added

comment:3 Changed 6 years ago by vbraun

  • Branch set to u/vbraun/allow_ctrl_c_to_interrupt_incomplete_multiline_sage_command

comment:4 Changed 6 years ago by vbraun

  • Authors set to Volker Braun
  • Commit set to bbaf9644f2b854e6b45a0177180705fc32d63c81
  • Status changed from new to needs_review

Fixed


New commits:

bbaf964Handle Ctrl-C in input hook on the C level

comment:5 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:6 Changed 6 years ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

This fixes the problem for me, and it still handles modifying attached files.

comment:7 Changed 6 years ago by vbraun

  • Branch changed from u/vbraun/allow_ctrl_c_to_interrupt_incomplete_multiline_sage_command to bbaf9644f2b854e6b45a0177180705fc32d63c81
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.