Opened 7 years ago

Closed 7 years ago

#16783 closed defect (fixed)

fix simplex in polytopes doc

Reported by: moritz Owned by:
Priority: trivial Milestone: sage-6.4
Component: geometry Keywords:
Cc: Merged in:
Authors: Moritz Firsching Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 6fda82f (Commits, GitHub, GitLab) Commit: 6fda82faa29b085369cabce45cb4f6c89d829330
Dependencies: Stopgaps:

Status badges

Description

for some reason it read "cross-polytopes" where it should read "simplex" in the doc of the polytope library. See patch, where it is corrected.

Change History (12)

comment:1 Changed 7 years ago by moritz

  • Status changed from new to needs_review

comment:2 Changed 7 years ago by chapoton

  • Authors changed from moritz to Moritz Firsching
  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

good to go

comment:3 Changed 7 years ago by vbraun

  • Status changed from positive_review to needs_work

Hmm branch name? I don't know what went wrong here...

comment:4 Changed 7 years ago by chapoton

Sorry, but what is the problem ? The former branch name was u/moritz/doc/polytopes

comment:5 Changed 7 years ago by vbraun

  • Branch changed from 6fda82faa29b085369cabce45cb4f6c89d829330 to u/moritz/doc/polytopes
  • Commit set to 6fda82faa29b085369cabce45cb4f6c89d829330

New commits:

6fda82fcrosspolytope to simplex

comment:6 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:7 Changed 7 years ago by moritz

what was wrong with it?

comment:8 Changed 7 years ago by vbraun

The "Branch" field must be the branch name, not commit sha1

comment:9 Changed 7 years ago by moritz

ok, great. So now its corrected, I will change to 'needs review' again?!

comment:10 Changed 7 years ago by moritz

  • Status changed from needs_work to needs_review

comment:11 Changed 7 years ago by vbraun

  • Status changed from needs_review to positive_review

comment:12 Changed 7 years ago by vbraun

  • Branch changed from u/moritz/doc/polytopes to 6fda82faa29b085369cabce45cb4f6c89d829330
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.