Opened 6 years ago
Closed 6 years ago
#16772 closed defect (fixed)
trivial bug when building OA(4,12)
Reported by: | ncohen | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-6.4 |
Component: | combinatorial designs | Keywords: | |
Cc: | vdelecroix, knsam, dimpase, brett | Merged in: | |
Authors: | Nathann Cohen | Reviewers: | Dima Pasechnik |
Report Upstream: | N/A | Work issues: | |
Branch: | b0a1a6a (Commits) | Commit: | b0a1a6ae4c6957b1d8595311d0c350b287b13741 |
Dependencies: | Stopgaps: |
Description
There is a missing [:k]
in the code, and Sage returns a OA(6,12)
even when only OA(4,12)
is requested. Well, it TRIES to return it, as nothing is returned by this function without being checked first :-P
Before
sage: OA = designs.orthogonal_array(4,12) ... AssertionError:
After
sage: OA = designs.orthogonal_array(4,12) sage:
Change History (8)
comment:1 Changed 6 years ago by
- Branch set to u/ncohen/16772
- Status changed from new to needs_review
comment:2 Changed 6 years ago by
- Commit set to b0a1a6ae4c6957b1d8595311d0c350b287b13741
comment:3 Changed 6 years ago by
what, no doctest?!
comment:4 Changed 6 years ago by
- Status changed from needs_review to positive_review
comment:5 Changed 6 years ago by
- Milestone changed from sage-6.3 to sage-6.4
comment:7 Changed 6 years ago by
- Reviewers set to Dima Pasechnik
- Status changed from needs_work to positive_review
comment:8 Changed 6 years ago by
- Branch changed from u/ncohen/16772 to b0a1a6ae4c6957b1d8595311d0c350b287b13741
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Branch pushed to git repo; I updated commit sha1. New commits:
trac #16772: trivial bug when building OA(4,12)