Opened 7 years ago

Closed 6 years ago

#16770 closed defect (fixed)

incorrect type of falling_factorial and rising_factorial with zero factors

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-6.4
Component: misc Keywords: incorrect type, factors
Cc: Merged in:
Authors: Daniel Krenn Reviewers: Ralf Stephan
Report Upstream: N/A Work issues:
Branch: dfc59bf (Commits, GitHub, GitLab) Commit: dfc59bf1dd299aff360ff9d1e6171639c29f3947
Dependencies: Stopgaps:

Status badges


We have

sage: type(falling_factorial(x,0))
<type 'sage.rings.integer.Integer'>
sage: type(falling_factorial(x,1))
<type 'sage.symbolic.expression.Expression'>

This is inconsistent and we want

sage: type(falling_factorial(x,0))
<type 'sage.symbolic.expression.Expression'>

Change History (7)

comment:1 Changed 7 years ago by dkrenn

  • Branch set to u/dkrenn/falling_factorials_type

comment:2 Changed 7 years ago by dkrenn

  • Authors set to Daniel Krenn
  • Commit set to dfc59bf1dd299aff360ff9d1e6171639c29f3947

Patch prepared (still running make ptestlong on my machine, so not ready for reviewing...)

New commits:

dfc59bftrac #16770: fixed type of falling_factorial with zero factors

comment:3 Changed 7 years ago by dkrenn

  • Status changed from new to needs_review

comment:4 Changed 7 years ago by dkrenn

All tests passed, so please review.

comment:5 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:6 Changed 6 years ago by rws

  • Reviewers set to Ralf Stephan
  • Status changed from needs_review to positive_review

Code is straightforward, passes doctests in all files using it.

comment:7 Changed 6 years ago by vbraun

  • Branch changed from u/dkrenn/falling_factorials_type to dfc59bf1dd299aff360ff9d1e6171639c29f3947
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.