Opened 5 years ago

Closed 5 years ago

#16763 closed enhancement (fixed)

New OA for n=189, plus some others through Vmt vectors

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.4
Component: combinatorial designs Keywords:
Cc: vdelecroix Merged in:
Authors: Nathann Cohen Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: bb21dc0 (Commits) Commit: bb21dc08709fa314c46305900164ec8a2ad68581
Dependencies: #16757 Stopgaps:

Description

A new OA for n=189 is implemented from its construction.

With a collection of Vmt vectors we also get new OA for n=1080, 1158, 1314, 1340, 1574, 2198, 2484, 2588, 2978, 892, 1068, 1134, 1992, 2058, 2850, 3004, 3510, 4302, 4500.

Nathann

Change History (12)

comment:1 Changed 5 years ago by ncohen

  • Branch set to u/ncohen/16763
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by git

  • Commit set to 0598e4659059d4743f9014e4c5ec8a240e93416b

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

​0232b73trac #16604: OA(20,544)
​e5f428dtrac #16604: Merged with 6.3.beta6
​355ac2atrac #16662: OA for n=1046,1059,2164,3992,3994
​15b449ctrac #16665: New OA for n=408,600,792,856,1368,2328,...
​a515deetrac #16673: Three factors construction of MOLS
​845de7atrac #16716: OA for n=262,950
​a9608c5trac #16722: OA(17,560)
​e5fc881trac #16722: Merged with 6.3.beta8
​698b704trac #16757: Organize the V(m,t) vectors into a dictionary
​0598e46trac #16763: New OA for n=189, plus some others through Vmt vectors

comment:3 Changed 5 years ago by git

  • Commit changed from 0598e4659059d4743f9014e4c5ec8a240e93416b to 7d6f4c68ca8c23303ea828ae5ab9c2ea573cf0c6

Branch pushed to git repo; I updated commit sha1. New commits:

​d26e2cdtrac #16763: Merged with 6.3.rc1
​7d6f4c6trac #16763: Complete bibliographical references

comment:4 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:5 Changed 5 years ago by git

  • Commit changed from 7d6f4c68ca8c23303ea828ae5ab9c2ea573cf0c6 to 5ba165ec2245286b3157d6c406830bdbaf3d0bf8

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​9cbc23ctrac #16673: Three factors construction of MOLS
​3fb8806trac #16673: review (one line simplicaction + doc)
​3458d22trac #16673: Merged with 6.4.beta1
​e48c1d3trac #16716: OA for n=262,950
​b9aa228trac #16722: OA(17,560)
​9a57f13trac #16757: Organize the V(m,t) vectors into a dictionary
​57c00f0trac #16757: doctest simplication
​424e229trac #16763: New OA for n=189, plus some others through Vmt vectors
​5ba165etrac #16763: Complete bibliographical references

comment:6 Changed 5 years ago by vdelecroix

Hello,

I am happy with the code. Just some small simplications at u/vdelecroix/16763 and then it could go to positive review.

Vincent

comment:7 Changed 5 years ago by vdelecroix

  • Status changed from needs_review to needs_info

comment:8 Changed 5 years ago by ncohen

  • Branch changed from u/ncohen/16763 to u/vdelecroix/16763
  • Commit changed from 5ba165ec2245286b3157d6c406830bdbaf3d0bf8 to f3f644d29d3c3592ecf97806b7f519fc7c2414af
  • Status changed from needs_info to positive_review

Goooooooood for me ! Thanks for this review !

Nathann

New commits:

​f3f644dtrac #16763: code simplification

comment:9 Changed 5 years ago by ncohen

  • Branch changed from u/vdelecroix/16763 to public/16763
  • Commit changed from f3f644d29d3c3592ecf97806b7f519fc7c2414af to bb21dc08709fa314c46305900164ec8a2ad68581

New commits:

​bb21dc0trac #16763: Double citation

comment:10 Changed 5 years ago by vbraun

  • Status changed from positive_review to needs_work

reviewer name

comment:11 Changed 5 years ago by ncohen

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_work to positive_review

comment:12 Changed 5 years ago by vbraun

  • Branch changed from public/16763 to bb21dc08709fa314c46305900164ec8a2ad68581
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.