Opened 6 years ago

Closed 6 years ago

#16760 closed defect (fixed)

stopgap for #16759

Reported by: jhpalmieri Owned by:
Priority: critical Milestone: sage-6.3
Component: packages: standard Keywords:
Cc: Merged in:
Authors: John Palmieri Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: b6711a4 (Commits) Commit: b6711a45ba18bc54cbf776d82f541ad08425476c
Dependencies: Stopgaps:

Description

Here is a stopgap for #16759: turn off install_package and print a message after installing a package via sage -i.

Change History (15)

comment:1 Changed 6 years ago by jhpalmieri

  • Branch set to u/jhpalmieri/install

comment:2 Changed 6 years ago by jdemeyer

  • Commit set to 836629cbea5e772bae77d869f1d7349b72647162

I know this is not yet needs_review, but could you move the message 

"It is a good idea to update the Sage library now: please run 'make' from \$SAGE_ROOT."

to src/bin/sage at the end of the install() function? That way, it will only be shown after an explicit package install (sage -i or sage -f), but not during the normal build.

New commits:

​836629cStopgap for #16759: disable install_package
Last edited 6 years ago by jdemeyer (previous) (diff)

comment:3 Changed 6 years ago by git

  • Commit changed from 836629cbea5e772bae77d869f1d7349b72647162 to d0b1b82747c2a1c6a8fbf08f0c62c79d2b91f2fc

Branch pushed to git repo; I updated commit sha1. New commits:

​d0b1b82Move message about running 'make' to install() in src/bin/sage

comment:4 Changed 6 years ago by git

  • Commit changed from d0b1b82747c2a1c6a8fbf08f0c62c79d2b91f2fc to e711f7753574b9739bf185931cb2314fa7254a47

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​e711f77Move message about running 'make' to install() in src/bin/sage

comment:5 Changed 6 years ago by git

  • Commit changed from e711f7753574b9739bf185931cb2314fa7254a47 to ad9994bee83cb50b3a681c4f5928a39e4afc8e18

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​ad9994bMove message about running 'make' to install() in src/bin/sage

comment:6 Changed 6 years ago by jhpalmieri

  • Status changed from new to needs_review

Good idea. I think I'll mark this as "needs review" now, although I haven't tested it very thoroughly. I'm not even sure it's the right thing to do...

comment:7 Changed 6 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer

comment:8 Changed 6 years ago by jdemeyer

This is sub-optimal, but I don't think it's a major problem: 

jdemeyer@tamiyo:/usr/local/src/sage-config$ ./sage -i pexpect
Found local metadata for pexpect-2.0.p6
Found local sources at /usr/local/src/sage-config/upstream/pexpect-2.0.tar.bz2
Package pexpect-2.0.p6 is already installed.
Use 'sage -f /usr/local/src/sage-config/upstream/pexpect-2.0.tar.bz2' to force a reinstallation.

It is a good idea to update the Sage library now: please run 'make' from $SAGE_ROOT.

comment:9 Changed 6 years ago by jdemeyer

  • Branch changed from u/jhpalmieri/install to u/jdemeyer/ticket/16760
  • Created changed from 08/05/14 01:23:06 to 08/05/14 01:23:06
  • Modified changed from 08/05/14 14:52:40 to 08/05/14 14:52:40

comment:10 Changed 6 years ago by jdemeyer

  • Commit changed from ad9994bee83cb50b3a681c4f5928a39e4afc8e18 to 4e12496227b7f704aa3b8dfbce4e4feb7b15cf46

A bit of a hack, but I think this does the job.

John, if you agree, then it's positive review.

New commits:

​4e12496Show the "please run make" message only if we actually installed something

comment:11 Changed 6 years ago by jhpalmieri

  • Branch changed from u/jdemeyer/ticket/16760 to u/jhpalmieri/ticket/16760

comment:12 follow-up: Changed 6 years ago by jhpalmieri

  • Commit changed from 4e12496227b7f704aa3b8dfbce4e4feb7b15cf46 to b6711a45ba18bc54cbf776d82f541ad08425476c
  • Status changed from needs_review to positive_review

Okay, good enough. (I made one small change on top of your commit: "bij" --> "by" in the comment in src/bin/sage.)

New commits:

​b6711a4Typo

comment:13 in reply to: ↑ 12 Changed 6 years ago by jdemeyer

Replying to jhpalmieri:

"bij" --> "by" in the comment in src/bin/sage.

Classic mistake: "bij" is a Dutch word...

Upgrading priority, a simple stopgap warrants this.

comment:14 Changed 6 years ago by jdemeyer

  • Priority changed from major to critical

comment:15 Changed 6 years ago by vbraun

  • Branch changed from u/jhpalmieri/ticket/16760 to b6711a45ba18bc54cbf776d82f541ad08425476c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.