Opened 5 years ago
Closed 5 years ago
#16757 closed enhancement (fixed)
Organize the V(m,t) vectors into a dictionary
Reported by:  ncohen  Owned by:  

Priority:  major  Milestone:  sage6.4 
Component:  combinatorial designs  Keywords:  
Cc:  vdelecroix  Merged in:  
Authors:  Nathann Cohen  Reviewers:  Vincent Delecroix 
Report Upstream:  N/A  Work issues:  
Branch:  57c00f0 (Commits)  Commit:  57c00f0a5d0ed574d33c0e5c0b81e89958753661 
Dependencies:  #16722  Stopgaps: 
Description
There are many Vmt vectors coming, and while the data of a Vmt is only <20 integers, adding one in Sage takes a total of 40 lines of code, because of the doc and everything (aways copy/pasted).
With this patch, all the V(m,t) vectors are now contained in a dictionary, and adding one takes 3 lines (one for the integers, one for the bibliographical reference, and one for the index at the top of the file).
Nathann
Change History (7)
comment:1 Changed 5 years ago by
 Branch set to u/ncohen/16757
 Status changed from new to needs_review
comment:2 Changed 5 years ago by
 Commit set to 698b704cc082ff99a9ecb56e67ebcb8808943806
comment:3 Changed 5 years ago by
 Milestone changed from sage6.3 to sage6.4
comment:4 Changed 5 years ago by
 Commit changed from 698b704cc082ff99a9ecb56e67ebcb8808943806 to 9a57f1312acf35c29e085a20f46a18da698c5c06
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
9cbc23c  trac #16673: Three factors construction of MOLS

3fb8806  trac #16673: review (one line simplicaction + doc)

3458d22  trac #16673: Merged with 6.4.beta1

e48c1d3  trac #16716: OA for n=262,950

b9aa228  trac #16722: OA(17,560)

9a57f13  trac #16757: Organize the V(m,t) vectors into a dictionary

comment:5 followup: ↓ 6 Changed 5 years ago by
 Reviewers set to Vincent Delecroix
1) The documentation in the dictionary is a bit strange... but it is modified in #16763. So it is fine for me as I will review the latter in a minute.
2) There is no need for an empty function to have a doctest. In u/vdelecroix/16757
I removed it and use a string alone. Drawback: there will be some conflict with #16763.
Beyond that it is fine... and could go to positive review.
Vincent
comment:6 in reply to: ↑ 5 Changed 5 years ago by
 Branch changed from u/ncohen/16757 to u/vdelecroix/16757
 Commit changed from 9a57f1312acf35c29e085a20f46a18da698c5c06 to 57c00f0a5d0ed574d33c0e5c0b81e89958753661
 Status changed from needs_review to positive_review
Yoooooooooo !!
1) The documentation in the dictionary is a bit strange... but it is modified in #16763. So it is fine for me as I will review the latter in a minute.
Yep, sorry for that ! I got an email from Julian about those references after submitting that commit.
2) There is no need for an empty function to have a doctest. In
u/vdelecroix/16757
I removed it and use a string alone. Drawback: there will be some conflict with #16763.
No prob, shouldn't be hard to fix. Thanks again !
Nathann
New commits:
57c00f0  trac #16757: doctest simplication

comment:7 Changed 5 years ago by
 Branch changed from u/vdelecroix/16757 to 57c00f0a5d0ed574d33c0e5c0b81e89958753661
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
trac #16604: OA(20,416)
trac #16604: OA(20,544)
trac #16604: Merged with 6.3.beta6
trac #16662: OA for n=1046,1059,2164,3992,3994
trac #16665: New OA for n=408,600,792,856,1368,2328,...
trac #16673: Three factors construction of MOLS
trac #16716: OA for n=262,950
trac #16722: OA(17,560)
trac #16722: Merged with 6.3.beta8
trac #16757: Organize the V(m,t) vectors into a dictionary