Opened 5 years ago

Closed 5 years ago

#16757 closed enhancement (fixed)

Organize the V(m,t) vectors into a dictionary

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.4
Component: combinatorial designs Keywords:
Cc: vdelecroix Merged in:
Authors: Nathann Cohen Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 57c00f0 (Commits) Commit: 57c00f0a5d0ed574d33c0e5c0b81e89958753661
Dependencies: #16722 Stopgaps:

Description

There are many Vmt vectors coming, and while the data of a Vmt is only <20 integers, adding one in Sage takes a total of 40 lines of code, because of the doc and everything (aways copy/pasted).

With this patch, all the V(m,t) vectors are now contained in a dictionary, and adding one takes 3 lines (one for the integers, one for the bibliographical reference, and one for the index at the top of the file).

Nathann

Change History (7)

comment:1 Changed 5 years ago by ncohen

  • Branch set to u/ncohen/16757
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by git

  • Commit set to 698b704cc082ff99a9ecb56e67ebcb8808943806

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

a621220trac #16604: OA(20,416)
0232b73trac #16604: OA(20,544)
e5f428dtrac #16604: Merged with 6.3.beta6
355ac2atrac #16662: OA for n=1046,1059,2164,3992,3994
15b449ctrac #16665: New OA for n=408,600,792,856,1368,2328,...
a515deetrac #16673: Three factors construction of MOLS
845de7atrac #16716: OA for n=262,950
a9608c5trac #16722: OA(17,560)
e5fc881trac #16722: Merged with 6.3.beta8
698b704trac #16757: Organize the V(m,t) vectors into a dictionary

comment:3 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:4 Changed 5 years ago by git

  • Commit changed from 698b704cc082ff99a9ecb56e67ebcb8808943806 to 9a57f1312acf35c29e085a20f46a18da698c5c06

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

9cbc23ctrac #16673: Three factors construction of MOLS
3fb8806trac #16673: review (one line simplicaction + doc)
3458d22trac #16673: Merged with 6.4.beta1
e48c1d3trac #16716: OA for n=262,950
b9aa228trac #16722: OA(17,560)
9a57f13trac #16757: Organize the V(m,t) vectors into a dictionary

comment:5 follow-up: Changed 5 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix

1) The documentation in the dictionary is a bit strange... but it is modified in #16763. So it is fine for me as I will review the latter in a minute.

2) There is no need for an empty function to have a doctest. In u/vdelecroix/16757 I removed it and use a string alone. Drawback: there will be some conflict with #16763.

Beyond that it is fine... and could go to positive review.

Vincent

comment:6 in reply to: ↑ 5 Changed 5 years ago by ncohen

  • Branch changed from u/ncohen/16757 to u/vdelecroix/16757
  • Commit changed from 9a57f1312acf35c29e085a20f46a18da698c5c06 to 57c00f0a5d0ed574d33c0e5c0b81e89958753661
  • Status changed from needs_review to positive_review

Yoooooooooo !!

1) The documentation in the dictionary is a bit strange... but it is modified in #16763. So it is fine for me as I will review the latter in a minute.

Yep, sorry for that ! I got an email from Julian about those references after submitting that commit.

2) There is no need for an empty function to have a doctest. In u/vdelecroix/16757 I removed it and use a string alone. Drawback: there will be some conflict with #16763.

No prob, shouldn't be hard to fix. Thanks again !

Nathann


New commits:

57c00f0trac #16757: doctest simplication

comment:7 Changed 5 years ago by vbraun

  • Branch changed from u/vdelecroix/16757 to 57c00f0a5d0ed574d33c0e5c0b81e89958753661
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.