Opened 6 years ago

Closed 6 years ago

#16756 closed defect (fixed)

Fully make lrcalc standard

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-6.4
Component: build Keywords: lrcalc deps
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: f17aaad (Commits) Commit: f17aaad6f47e88558d4f6d59277c206b5849de8b
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

build/deps should reflect the dependency of sage on lrcalc.

Change History (7)

comment:1 Changed 6 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Description modified (diff)

comment:2 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/16756
  • Created changed from 08/04/14 13:55:26 to 08/04/14 13:55:26
  • Modified changed from 08/04/14 14:00:41 to 08/04/14 14:00:41

comment:3 Changed 6 years ago by jdemeyer

  • Commit set to f17aaad6f47e88558d4f6d59277c206b5849de8b
  • Status changed from new to needs_review

New commits:

f17aaadAdd LRCALC as dependency of sage

comment:4 follow-up: Changed 6 years ago by jhpalmieri

  • Keywords lrcalc deps added
  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

Looks okay to me. I guess the files in src/sage/libs/lrcalc demonstrate that this is a build-time dependency, not just a run-time one?

comment:5 in reply to: ↑ 4 Changed 6 years ago by jdemeyer

Replying to jhpalmieri:

Looks okay to me. I guess the files in src/sage/libs/lrcalc demonstrate that this is a build-time dependency, not just a run-time one?

It is indeed a build dependency, look at src/module_list.py which has

if is_package_installed('lrcalc'):
    ext_modules.append(
        Extension('sage.libs.lrcalc.lrcalc',
                  sources = ["sage/libs/lrcalc/lrcalc.pyx"],
                  include_dirs = [SAGE_INC + '/lrcalc/'],
                  libraries = ["lrcalc"],
                  depends = [SAGE_INC + "/lrcalc/symfcn.h"]), # should include all .h
        )

comment:6 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:7 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/16756 to f17aaad6f47e88558d4f6d59277c206b5849de8b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.