Opened 6 years ago

Closed 6 years ago

#16741 closed defect (fixed)

Bug in IncidenceStructure.automorphism_group when the ground set consists of pairs

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.3
Component: combinatorial designs Keywords:
Cc: vdelecroix, knsam, dimpase Merged in:
Authors: Nathann Cohen Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: aad8ee5 (Commits) Commit:
Dependencies: Stopgaps:

Description (last modified by ncohen)

Before 

sage: designs.IncidenceStructure([[(1,2),(3,4)]]).automorphism_group()
...
ValueError: Invalid permutation vector: [(3, 4), (1, 2)]

After 

sage: designs.IncidenceStructure([[(1,2),(3,4)]]).automorphism_group()
Permutation Group with generators [((1,2),(3,4))]

Change History (11)

comment:1 Changed 6 years ago by ncohen

  • Branch set to u/ncohen/16741
  • Description modified (diff)
  • Status changed from new to needs_review

This really was triky to fix. The permutation code tries to handle several incompatible input i.e. tries to guess whether input is given in list notation or cycle notation, and guesses that from the type list/tuple of input.

Plus some permutation code WANTS permutations on 1...n, others on 0,...,n-1 and others handle everything...

comment:2 Changed 6 years ago by git

  • Commit set to aad8ee5de146babdc8873c0dd7fa64340e064590

Branch pushed to git repo; I updated commit sha1. New commits:

​aad8ee5trac #16741: Bug in IncidenceStructure.relabel when the ground set consists of pairs

comment:3 Changed 6 years ago by dimpase

when I read the permgroups code, I think: "FORTRAN" :-)

comment:4 Changed 6 years ago by ncohen

  • Summary changed from Bug in IncidenceStructure.relabel when the ground set consists of pairs to Bug in IncidenceStructure.automorphism_group when the ground set consists of pairs

comment:5 Changed 6 years ago by dimpase

  • Status changed from needs_review to positive_review

LGTM

comment:6 Changed 6 years ago by ncohen

Thaaaaaaaannks !

Nathann

comment:7 Changed 6 years ago by vbraun

  • Status changed from positive_review to needs_work

name

comment:8 Changed 6 years ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_work to positive_review

comment:9 Changed 6 years ago by vbraun

  • Branch changed from u/ncohen/16741 to aad8ee5de146babdc8873c0dd7fa64340e064590
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:10 Changed 6 years ago by vbraun

  • Commit aad8ee5de146babdc8873c0dd7fa64340e064590 deleted
  • Resolution fixed deleted
  • Status changed from closed to new

PDF docs: 

LaTeX Warning: Hyper reference `sage/combinat/designs/incidence_structures:sage
.combinat.designs.incidence_structures.IncidenceStructure.is_t_design' on page 
244 undefined on input line 20504.

[244] [245] [246]
! Double subscript.
l.20746 ...tion, see the ;wikipedia:$Packing_in_a_
                                                  hypergraph$.

comment:11 Changed 6 years ago by vbraun

  • Resolution set to fixed
  • Status changed from new to closed

wrong ticket

Note: See TracTickets for help on using tickets.