Opened 5 years ago

Closed 5 years ago

#16733 closed enhancement (fixed)

docutils-0.12

Reported by: vbraun Owned by:
Priority: major Milestone: sage-6.4
Component: packages: standard Keywords:
Cc: fbissey, jpflori, chapoton, strogdon, Snark Merged in:
Authors: Volker Braun Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: a018444 (Commits) Commit: a0184448f499fe7107b9da3edc629f4af90a3e14
Dependencies: #16396 Stopgaps:

Description (last modified by vbraun)

Straightforward update to the newest docutils. Requires sphinx patch that is taken from upstream.

http://boxen.math.washington.edu/home/vbraun/upstream/docutils-0.12.tar.gz

Change History (22)

comment:1 Changed 5 years ago by vbraun

  • Component changed from PLEASE CHANGE to packages: standard
  • Description modified (diff)
  • Type changed from PLEASE CHANGE to enhancement

comment:2 Changed 5 years ago by vbraun

  • Authors set to Volker Braun
  • Description modified (diff)

comment:3 Changed 5 years ago by vbraun

  • Branch set to u/vbraun/docutils_0_12

comment:4 Changed 5 years ago by vbraun

  • Cc fbissey jpflori chapoton strogdon added
  • Commit set to 5967e1d1c78e56c839fdc3066dce0b384d180cde

New commits:

a992b04update to docutils-0.12
5967e1dadd sphinx patch for docutils >= 0.9

comment:5 Changed 5 years ago by vbraun

  • Status changed from new to needs_review

comment:6 Changed 5 years ago by fbissey

Actually Gentoo is still at 0.11 but if the patchbot is OK with it I have no problem with it. In our experience 0.10 is toxic but no other release is.

comment:7 Changed 5 years ago by vbraun

  • Reviewers set to François Bissey
  • Status changed from needs_review to positive_review

Thanks!

comment:8 Changed 5 years ago by vbraun

  • Dependencies set to #16736

comment:9 Changed 5 years ago by fbissey

Since we are holding this I thought of something. Does the bot report doctests failures? I now remember that in sage-on-gentoo we had a small issue with a docutils upgrade: https://github.com/cschwan/sage-on-gentoo/issues/197 I had to add a couple of empty __init__.py to suppress some warnings appearing in doctests.

comment:10 Changed 5 years ago by vbraun

I ran this ticket + #16736 on the buildbot and there were no failures. I just didn't want to wait with beta8. Really, both tickets are ready and it just takes somebody to click on positive review.

comment:11 Changed 5 years ago by fbissey

I'll have to check if the files have been added since then, then. Or may be it was docutils 0.9. Looking at the other ticket.

comment:12 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:13 Changed 5 years ago by Snark

  • Cc Snark added
  • Dependencies changed from #16736 to #16736, #16396
  • Status changed from positive_review to needs_work

Let me put that ticket back to needs_work: the added patch is unneeded in sphinx 1.2.2.

I also add a dep on #16396, which is precisely about going up to sphinx 1.2, hence making the patch obsolete.

comment:14 Changed 5 years ago by strogdon

  • Branch changed from u/vbraun/docutils_0_12 to u/strogdon/docutils_0_12

comment:15 Changed 5 years ago by strogdon

  • Commit changed from 5967e1d1c78e56c839fdc3066dce0b384d180cde to a0184448f499fe7107b9da3edc629f4af90a3e14
  • Status changed from needs_work to needs_review

Hopefully, I removed the sphinx patches and if successful it should be ready for review.


New commits:

a018444Revert "add sphinx patch for docutils >= 0.9"

comment:16 Changed 5 years ago by fbissey

  • Status changed from needs_review to positive_review

I am putting this as positive review any trouble will be caught by the bot when it is back on.

comment:17 Changed 5 years ago by Snark

I tried to compile&ptestlong the u/vbraun/docutils_0_12 branch, and got a lot of failing doctests... I don't have much time to dig through but it looks like a problem with some kind of graph database... Is it an unrelated breakage?

comment:18 Changed 5 years ago by fbissey

Cannot say without seeing any output really.

comment:19 Changed 5 years ago by Snark

I found the time to have a look : it looks like the failing tests have something to do with fetching graphs from some kind of SQLite database, as I have errors stating that there is no table named 'graph_data' everywhere ; so it looks like it's unrelated.

comment:20 Changed 5 years ago by Snark

Good news : I started from master, merged the branch, recompiled everything, retested: all tests pass! So count me in for a positive review :-)

comment:21 Changed 5 years ago by vbraun

  • Dependencies changed from #16736, #16396 to #16396

comment:22 Changed 5 years ago by vbraun

  • Branch changed from u/strogdon/docutils_0_12 to a0184448f499fe7107b9da3edc629f4af90a3e14
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.