Opened 5 years ago
Closed 5 years ago
#16731 closed defect (fixed)
Uncaught preparser syntaxerror
Reported by:  vbraun  Owned by:  

Priority:  major  Milestone:  sage6.4 
Component:  user interface  Keywords:  
Cc:  gmoroz  Merged in:  
Authors:  Volker Braun  Reviewers:  Frédéric Chapoton 
Report Upstream:  N/A  Work issues:  
Branch:  3833039 (Commits)  Commit:  38330399caa409fcf53015c73a3dd082a5f87a55 
Dependencies:  Stopgaps: 
Description (last modified by )
This (+return) crashes Sage with a preparser error:
sage: R.<x> = #note the final space
Change History (16)
comment:1 Changed 5 years ago by
 Cc gmoroz added
comment:2 Changed 5 years ago by
 Description modified (diff)
comment:3 Changed 5 years ago by
 Branch set to u/vbraun/uncaught_preparser_syntaxerror
comment:4 Changed 5 years ago by
 Commit set to e2b6d9f8a6dc4a6f8212d34c3565641c35ea9cc2
 Status changed from new to needs_review
comment:5 Changed 5 years ago by
 Branch changed from u/vbraun/uncaught_preparser_syntaxerror to public/ticket/16731
 Commit changed from e2b6d9f8a6dc4a6f8212d34c3565641c35ea9cc2 to 77a601f46ccfb31f625dd949a4b560bb232b2bc9
Hello, sorry, I could not resist to make a few small changes:
 make sure that the imports are only one per line
 removed two unused variables found by pyflakes
 add doc to one function
If you agree with that, you can set a positive review on my behalf.
New commits:
77a601f  trac #16731 removed unused variables ; only one import per line ; more doc

comment:6 Changed 5 years ago by
Ping ?
comment:7 Changed 5 years ago by
Removing unused stuff is good, but just commenting out dead code and leaving it like a shit stain in the living room is bad ;)
comment:8 Changed 5 years ago by
 Status changed from needs_review to needs_work
comment:9 Changed 5 years ago by
 Commit changed from 77a601f46ccfb31f625dd949a4b560bb232b2bc9 to a67d5883f16ff030e657785808cffeb7b1e21dbe
comment:10 Changed 5 years ago by
 Reviewers set to Frédéric Chapoton
 Status changed from needs_work to needs_review
Hello,
better like that ?
comment:12 Changed 5 years ago by
 Status changed from positive_review to needs_work
Documentation doesn't build
LaTeX Warning: Hyper reference `sage/misc/preparser:sage.misc.preparser.load' o n page 190 undefined on input line 14390. ! Missing { inserted. <to be read again> $ l.14427 ...y string of digits or just a single $_$
comment:13 Changed 5 years ago by
 Commit changed from a67d5883f16ff030e657785808cffeb7b1e21dbe to 38330399caa409fcf53015c73a3dd082a5f87a55
Branch pushed to git repo; I updated commit sha1. New commits:
3833039  trac #16731 taking care of ill underscore in doc

comment:14 Changed 5 years ago by
 Status changed from needs_work to positive_review
damn.. Maybe now ?
comment:15 Changed 5 years ago by
 Milestone changed from sage6.3 to sage6.4
comment:16 Changed 5 years ago by
 Branch changed from public/ticket/16731 to 38330399caa409fcf53015c73a3dd082a5f87a55
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
fix preparser for certain illegal input