Opened 4 years ago

Closed 4 years ago

#16730 closed enhancement (fixed)

PermutationGroup.blocks_all with correct labels

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.3
Component: group theory Keywords:
Cc: vdelecroix, dimpase Merged in:
Authors: Nathann Cohen Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: fa8928a (Commits) Commit: fa8928ae9903ab2ec728c56c25961ee0ab95bd72
Dependencies: Stopgaps:

Description

Before

sage: g = PermutationGroup([("a","b","c","d")])
sage: g.blocks_all()
[[1, 3]]
sage: g.blocks_all(False)
[[[1, 3], [2, 4]]]

After

sage: g = PermutationGroup([("a","b","c","d")])
sage: g.blocks_all()
[['a', 'c']]
sage: g.blocks_all(False)
[[['a', 'c'], ['b', 'd']]]  

Change History (5)

comment:1 Changed 4 years ago by ncohen

  • Branch set to u/ncohen/16730
  • Commit set to e79d50feb06255deaf904b3cd4fc795a6c438a74
  • Status changed from new to needs_review

New commits:

e79d50ftrac #16730: PermutationGroup.blocks_all with correct labels

comment:2 Changed 4 years ago by dimpase

  • Branch changed from u/ncohen/16730 to u/dimpase/16730
  • Commit changed from e79d50feb06255deaf904b3cd4fc795a6c438a74 to fa8928ae9903ab2ec728c56c25961ee0ab95bd72
  • Reviewers set to Dima Pasechnik

New commits:

e79d50ftrac #16730: PermutationGroup.blocks_all with correct labels
fa8928afixed typos in dostrings

comment:3 follow-up: Changed 4 years ago by dimpase

  • Status changed from needs_review to positive_review

fixed typos in the doc along the way. Otherwise, looks good to me.

comment:4 in reply to: ↑ 3 Changed 4 years ago by ncohen

fixed typos in the doc along the way. Otherwise, looks good to me.

Thanks ! Well, then let's say that I "reviewed" your typo fix ;-)

Nathann

comment:5 Changed 4 years ago by vbraun

  • Branch changed from u/dimpase/16730 to fa8928ae9903ab2ec728c56c25961ee0ab95bd72
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.