Opened 7 years ago

Closed 7 years ago

#16728 closed defect (fixed)

libgap_workspace_2

Reported by: vbraun Owned by:
Priority: blocker Milestone: sage-6.3
Component: group theory Keywords:
Cc: Merged in:
Authors: Volker Braun Reviewers: Ralf Stephan
Report Upstream: N/A Work issues:
Branch: 80d484e (Commits) Commit: 80d484ebbf534f6ea79bdb180b9fe1455e8630a6
Dependencies: Stopgaps:

Description (last modified by vbraun)

The new saved-workspace feature fails under certain conditions:

        from sage.libs.gap.libgap import libgap
      File "libgap.pyx", line 776, in init sage.libs.gap.libgap (build/cythonized/sage/libs/gap/libgap.c:6772)
      File "libgap.pyx", line 597, in sage.libs.gap.libgap.Gap.__init__ (build/cythonized/sage/libs/gap/libgap.c:4784)
      File "util.pyx", line 245, in sage.libs.gap.util.initialize (build/cythonized/sage/libs/gap/util.c:4395)
      File "util.pyx", line 204, in sage.libs.gap.util.libgap_workspace (build/cythonized/sage/libs/gap/util.c:4113)
    ValueError: max() arg is an empty sequence

Change History (9)

comment:1 Changed 7 years ago by vbraun

  • Component changed from PLEASE CHANGE to group theory
  • Description modified (diff)
  • Priority changed from major to blocker
  • Type changed from PLEASE CHANGE to defect

comment:2 Changed 7 years ago by rws

I have in local/lib64:

libec.a         libgap.so        libgf2x.so.1      liblrcalc.so.0.0.0  libmpc.so.3
libec.la        libgap.so.0      libgf2x.so.1.0.0  liblrcalc.so.1      libmpc.so.3.0.0
libec.so        libgap.so.0.0.0  liblrcalc.a       liblrcalc.so.1.0.0
libec.so.0      libgf2x.a        liblrcalc.la      libmpc.a
libec.so.0.0.0  libgf2x.la       liblrcalc.so      libmpc.la
libgap.la       libgf2x.so       liblrcalc.so.0    libmpc.so

-rwxr-xr-x 1 ralf users     983 Jul 29 14:49 local/lib64/libgap.la*
lrwxrwxrwx 1 ralf users      15 Jul  1 11:00 local/lib64/libgap.so -> libgap.so.0.0.0*
lrwxrwxrwx 1 ralf users      15 Jul  1 11:00 local/lib64/libgap.so.0 -> libgap.so.0.0.0*
-rwxr-xr-x 1 ralf users 3262386 Jul  1 11:00 local/lib64/libgap.so.0.0.0*

(sage-sh) ralf@ark:sage$ set|grep LD_
LD_LIBRARY_PATH=/home/ralf/sage/local/lib:/home/ralf/sage/local/lib64:/home/ralf/sage/local/lib/R/lib

System is OpenSuSE 12.3. I also have local/lib/python2.7/site-packages/sage/libs/gap/libgap.so but I don't think that's relevant here? These are the only files with name libgap.so*

For completeness, when I take back commit 02a25d5626c0527e81559d3229ac6b6f64d35978 every complaint made goes away.

comment:3 Changed 7 years ago by vbraun

  • Branch set to u/vbraun/libgap_workspace_2

comment:4 Changed 7 years ago by vbraun

  • Commit set to 80d484ebbf534f6ea79bdb180b9fe1455e8630a6

Fixed to not depend directly on the libdir (only indirectly through cythonize -> extension module timestamp)


New commits:

3387487Make the libgap workspace timestamp less fragile
80d484eSet libdir when configuring libgap

comment:5 Changed 7 years ago by vbraun

  • Authors set to Volker Braun
  • Status changed from new to needs_review

comment:6 Changed 7 years ago by rws

Doctests in graphs/ pass now, and the documentation gets built. Do we need a ptestlong?

comment:7 Changed 7 years ago by vbraun

  • Reviewers set to Ralf Stephan

I'll run it on the buildbot and then make a beta8 since this is bound to affect many users.

comment:8 Changed 7 years ago by vbraun

  • Status changed from needs_review to positive_review

comment:9 Changed 7 years ago by vbraun

  • Branch changed from u/vbraun/libgap_workspace_2 to 80d484ebbf534f6ea79bdb180b9fe1455e8630a6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.