Opened 5 years ago

Closed 5 years ago

#16717 closed defect (fixed)

Python3: next in finite_state_machines module

Reported by: dkrenn Owned by:
Priority: minor Milestone: sage-6.3
Component: finite state machines Keywords: python3, next
Cc: cheuberg, skropf Merged in:
Authors: Daniel Krenn Reviewers: Clemens Heuberger
Report Upstream: N/A Work issues:
Branch: 4d77478 (Commits) Commit: 4d77478cb220f31f8b91e6357779244679cea48d
Dependencies: Stopgaps:

Description

Changing .next() to next(...) for Python 3 porting.

Change History (8)

comment:1 Changed 5 years ago by dkrenn

  • Branch set to u/dkrenn/fsm/next

comment:2 Changed 5 years ago by dkrenn

  • Authors set to Daniel Krenn
  • Commit set to 169b80c85f7dead04eb9428659a76539b06bf600
  • Status changed from new to needs_review

Changed all occurrences of .next except for those in FSMProcessIterator, since those will be changed in #16538.

comment:3 Changed 5 years ago by aapitzsch

Your branch does not contain any changes compared with 6.3.beta6.

comment:4 Changed 5 years ago by git

  • Commit changed from 169b80c85f7dead04eb9428659a76539b06bf600 to 4d77478cb220f31f8b91e6357779244679cea48d

Branch pushed to git repo; I updated commit sha1. New commits:

​4d77478Changed occurrences of .next except for those in FSMProcessIterator to next (Python 3)

comment:5 Changed 5 years ago by dkrenn

Uuups.....pushed wrong branch. Now there should be a change ;)

comment:6 Changed 5 years ago by cheuberg

  • Status changed from needs_review to positive_review

merges cleanly, doctests pass, no changes in documentation. It probably does not hurt to have these replacements at this stage. #16075 is tasked with the switch at a more global level, but has no branch attached yet, so no merge conflicts expected at this stage.

comment:7 Changed 5 years ago by cheuberg

  • Reviewers set to Clemens Heuberger

comment:8 Changed 5 years ago by vbraun

  • Branch changed from u/dkrenn/fsm/next to 4d77478cb220f31f8b91e6357779244679cea48d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.