Opened 5 years ago

Closed 5 years ago

#16709 closed enhancement (fixed)

IncidenceStructure.packing

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.3
Component: combinatorial designs Keywords:
Cc: vdelecroix, knsam, dimpase, brett Merged in:
Authors: Nathann Cohen Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 6edd826 (Commits) Commit: 6edd8267a9a3bc91f3327662134ccb6279ba5b20
Dependencies: #16701 Stopgaps:

Description

A Good Old ILP for a NP-Hard problem. Reminds me of the early days of Graphs in Sage :-P

Nathann

Change History (14)

comment:1 Changed 5 years ago by ncohen

  • Branch set to u/ncohen/16709
  • Dependencies set to #16701
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by git

  • Commit set to 8b05ae8c1afdb03640d125feafd59bb4427b9286

Branch pushed to git repo; I updated commit sha1. New commits:

9c7d82etrac #16701: IncidenceStructure.degree
5a11312trac #16701: A fix for a blasphemy
ec241b8trac #16701: Tribute to pep8 fascism
8b05ae8trac #16709: IncidenceStructure.packing

comment:3 Changed 5 years ago by git

  • Commit changed from 8b05ae8c1afdb03640d125feafd59bb4427b9286 to 3a6f43dcc6e02bf7261e5ac809fa8bf0b4c4c582

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

3a6f43dtrac #16709: IncidenceStructure.packing

comment:4 follow-up: Changed 5 years ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

LGTM.

By the way, I noticed weirdness in designs.steiner_quadruple_system -- these guys aren't Incidence system, they are just dumps of tuples...

comment:5 follow-up: Changed 5 years ago by dimpase

PS. one ought to have .covering() too, not only .packing().

comment:6 in reply to: ↑ 4 Changed 5 years ago by ncohen

Yo !

Thanks for the review !

By the way, I noticed weirdness in designs.steiner_quadruple_system -- these guys aren't Incidence system, they are just dumps of tuples...

Well, write a ticket if you care (I will review it), otherwise I'll do it someday. I was against it some time ago, but that was before Vincent's patch to renovate the incidence structure code. It used to be buggy and unmaintained, but now it is on a better road. Let's use it.

Nathann

comment:7 in reply to: ↑ 5 Changed 5 years ago by ncohen

PS. one ought to have .covering() too, not only .packing().

Same here, write a patch if you care (like for packing it only takes 10 lines of LP) otherwise it will be done someday. Though I hit packing problems much more often than covering ones, so it may not be tomorrow :-P

Nathann

comment:8 Changed 5 years ago by vbraun

  • Branch changed from u/ncohen/16709 to 3a6f43dcc6e02bf7261e5ac809fa8bf0b4c4c582
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:9 Changed 5 years ago by vbraun

  • Commit 3a6f43dcc6e02bf7261e5ac809fa8bf0b4c4c582 deleted

PDF Docs:

LaTeX Warning: Hyper reference `sage/combinat/designs/incidence_structures:sage
.combinat.designs.incidence_structures.IncidenceStructure.is_t_design' on page 
244 undefined on input line 20504.

[244] [245] [246]
! Double subscript.
l.20746 ...tion, see the ;wikipedia:$Packing_in_a_
                                                  hypergraph$.

comment:10 Changed 5 years ago by ncohen

  • Resolution fixed deleted
  • Status changed from closed to new

:-/

comment:11 Changed 5 years ago by ncohen

  • Branch changed from 3a6f43dcc6e02bf7261e5ac809fa8bf0b4c4c582 to u/ncohen/16709
  • Commit set to 6edd8267a9a3bc91f3327662134ccb6279ba5b20
  • Status changed from new to needs_review

New commits:

3a6f43dtrac #16709: IncidenceStructure.packing
354c830trac #16709: Merged with 6.3.beta8
6edd826trac #16709: Broken doc

comment:12 Changed 5 years ago by ncohen

  • Status changed from needs_review to positive_review

comment:13 Changed 5 years ago by dimpase

right, ; -> :

comment:14 Changed 5 years ago by vbraun

  • Branch changed from u/ncohen/16709 to 6edd8267a9a3bc91f3327662134ccb6279ba5b20
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.