Opened 5 years ago

Closed 5 years ago

#16701 closed enhancement (fixed)

IncidenceStructure.degree

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.3
Component: combinatorial designs Keywords:
Cc: vdelecroix, knsam, dimpase, brett Merged in:
Authors: Nathann Cohen Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: ec241b8 (Commits) Commit: ec241b8550367f0844b1b6f1d793363563569987
Dependencies: Stopgaps:

Description

That's all !

Nathann

Change History (15)

comment:1 Changed 5 years ago by ncohen

  • Branch set to u/ncohen/16701
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by git

  • Commit set to 9c7d82e76d80e7b4a83e90ad73053308721d5b90

Branch pushed to git repo; I updated commit sha1. New commits:

​9c7d82etrac #16701: IncidenceStructure.degree

comment:3 Changed 5 years ago by dimpase

please change 

associating a point with its degree is returned.

to 

associating the points with their degrees is returned.

comment:4 Changed 5 years ago by git

  • Commit changed from 9c7d82e76d80e7b4a83e90ad73053308721d5b90 to 5a113127005880095a10474c8e043c5370bf8e88

Branch pushed to git repo; I updated commit sha1. New commits:

​5a11312trac #16701: A fix for a blasphemy

comment:5 Changed 5 years ago by dimpase

and the spacing, around =, etc, it's so, so un-PEP-8...

comment:6 Changed 5 years ago by git

  • Commit changed from 5a113127005880095a10474c8e043c5370bf8e88 to ec241b8550367f0844b1b6f1d793363563569987

Branch pushed to git repo; I updated commit sha1. New commits:

​ec241b8trac #16701: Tribute to pep8 fascism

comment:7 follow-up: Changed 5 years ago by dimpase

p=None -> p = None, please...

comment:8 in reply to: ↑ 7 Changed 5 years ago by ncohen

Replying to dimpase:

p=None -> p = None, please...

Over my dead body. Here is the outut of pep8 when I do the change you want :

incidence_structures.py:471:23: E251 unexpected spaces around keyword / parameter equals

Nathann

comment:9 Changed 5 years ago by dimpase

  • Status changed from needs_review to positive_review

OK...

comment:10 Changed 5 years ago by ncohen

Thaaaaaaaaaaaanks :-P

Nathann

comment:11 Changed 5 years ago by vbraun

  • Status changed from positive_review to needs_work

Reviewer name

comment:12 Changed 5 years ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_work to positive_review

comment:13 Changed 5 years ago by ncohen

  • Reviewers Dima Pasechnik deleted
  • Status changed from positive_review to needs_info
Last edited 5 years ago by ncohen (previous) (diff)

comment:14 Changed 5 years ago by ncohen

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_info to positive_review

Wrong ticket.

comment:15 Changed 5 years ago by vbraun

  • Branch changed from u/ncohen/16701 to ec241b8550367f0844b1b6f1d793363563569987
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.