Opened 4 years ago
Closed 4 years ago
#16701 closed enhancement (fixed)
IncidenceStructure.degree
Reported by:  ncohen  Owned by:  

Priority:  major  Milestone:  sage6.3 
Component:  combinatorial designs  Keywords:  
Cc:  vdelecroix, knsam, dimpase, brett  Merged in:  
Authors:  Nathann Cohen  Reviewers:  Dima Pasechnik 
Report Upstream:  N/A  Work issues:  
Branch:  ec241b8 (Commits)  Commit:  ec241b8550367f0844b1b6f1d793363563569987 
Dependencies:  Stopgaps: 
Description
That's all !
Nathann
Change History (15)
comment:1 Changed 4 years ago by
 Branch set to u/ncohen/16701
 Status changed from new to needs_review
comment:2 Changed 4 years ago by
 Commit set to 9c7d82e76d80e7b4a83e90ad73053308721d5b90
comment:3 Changed 4 years ago by
please change
associating a point with its degree is returned.
to
associating the points with their degrees is returned.
comment:4 Changed 4 years ago by
 Commit changed from 9c7d82e76d80e7b4a83e90ad73053308721d5b90 to 5a113127005880095a10474c8e043c5370bf8e88
Branch pushed to git repo; I updated commit sha1. New commits:
5a11312  trac #16701: A fix for a blasphemy

comment:5 Changed 4 years ago by
and the spacing, around =
, etc, it's so, so unPEP8...
comment:6 Changed 4 years ago by
 Commit changed from 5a113127005880095a10474c8e043c5370bf8e88 to ec241b8550367f0844b1b6f1d793363563569987
Branch pushed to git repo; I updated commit sha1. New commits:
ec241b8  trac #16701: Tribute to pep8 fascism

comment:7 followup: ↓ 8 Changed 4 years ago by
p=None
> p = None
, please...
comment:8 in reply to: ↑ 7 Changed 4 years ago by
Replying to dimpase:
p=None
>p = None
, please...
Over my dead body. Here is the outut of pep8 when I do the change you want :
incidence_structures.py:471:23: E251 unexpected spaces around keyword / parameter equals
Nathann
comment:10 Changed 4 years ago by
Thaaaaaaaaaaaanks :P
Nathann
comment:12 Changed 4 years ago by
 Reviewers set to Dima Pasechnik
 Status changed from needs_work to positive_review
comment:13 Changed 4 years ago by
 Reviewers Dima Pasechnik deleted
 Status changed from positive_review to needs_info
comment:14 Changed 4 years ago by
 Reviewers set to Dima Pasechnik
 Status changed from needs_info to positive_review
Wrong ticket.
comment:15 Changed 4 years ago by
 Branch changed from u/ncohen/16701 to ec241b8550367f0844b1b6f1d793363563569987
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Branch pushed to git repo; I updated commit sha1. New commits:
trac #16701: IncidenceStructure.degree