Opened 8 years ago

Closed 8 years ago

#16700 closed defect (fixed)

fix latex of bimodules

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-6.3
Component: algebra Keywords: latex
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 3f6022a (Commits, GitHub, GitLab) Commit: 3f6022aef8d21c7b48ebf11196055a1bce6da5c5
Dependencies: Stopgaps:

Status badges

Description

The Latex method of bimodules does not compile, because of a double underscore.

Change History (6)

comment:1 Changed 8 years ago by chapoton

  • Authors set to Frédéric Chapoton
  • Branch set to u/chapoton/16700
  • Commit set to 7d1d711dbc0e9202a94bfa87a0ebc75d367d7968
  • Status changed from new to needs_review

New commits:

​7d1d711trac #16700 correct latex of bimodules

comment:2 Changed 8 years ago by chapoton

  • Component changed from PLEASE CHANGE to algebra

comment:3 Changed 8 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Very minor, but could you can it to use format: 

return "{{{}}}_{{{}, {}}}".format(Category._latex_(self),
                                  latex(self._left_base_ring),
                                  latex(self._right_base_ring))

Once done, you can set a positive review on my behalf. If you don't want to change this, then you can just set a positive review as well. Thanks.

comment:4 Changed 8 years ago by git

  • Commit changed from 7d1d711dbc0e9202a94bfa87a0ebc75d367d7968 to 3f6022aef8d21c7b48ebf11196055a1bce6da5c5

Branch pushed to git repo; I updated commit sha1. New commits:

​3f6022atrac #16700 using .format instead of %

comment:5 Changed 8 years ago by chapoton

  • Status changed from needs_review to positive_review

Thanks, Travis.

comment:6 Changed 8 years ago by vbraun

  • Branch changed from u/chapoton/16700 to 3f6022aef8d21c7b48ebf11196055a1bce6da5c5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.