Opened 5 years ago

Closed 5 years ago

#16698 closed task (fixed)

remove deprecated prec arguments

Reported by: rws Owned by:
Priority: trivial Milestone: sage-duplicate/invalid/wontfix
Component: numerical Keywords: prec, keyword, deprecation, deprecated, beginner
Cc: Merged in:
Authors: André Apitzsch Reviewers:
Report Upstream: N/A Work issues:
Branch: u/aapitzsch/ticket/16698 (Commits) Commit: ba38202cf55caefb032e1b4519c96b9706577004
Dependencies: Stopgaps:

Description (last modified by aapitzsch)

There are still three instances of the prec keyword argument:

src/sage/functions/other.py:            deprecation(7490, "The prec keyword argument is deprecated. Explicitly set the precision of the input, for example gamma(RealField(300)(1)), or use the prec argument to .n() for exact inputs, e.g., gamma(1).n(300), instead.")
src/sage/functions/other.py:            deprecation(7490, "Calling symbolic functions with arguments that cannot be coerced into symbolic expressions is deprecated.")
src/sage/functions/log.py:            deprecation(7490, "The prec keyword argument is deprecated. Explicitly set the precision of the input, for example exp(RealField(300)(1)), or use the prec argument to .n() for exact inputs, e.g., exp(1).n(300), instead.")

Change History (10)

comment:1 Changed 5 years ago by rws

  • Keywords beginner added
  • Priority changed from major to trivial

comment:2 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:3 Changed 5 years ago by aapitzsch

  • Authors set to André Apitzsch
  • Branch set to u/aapitzsch/ticket/16698
  • Commit set to 2cf6f69523d1b750ea180407d7af402739f9459f

comment:4 Changed 5 years ago by aapitzsch

  • Status changed from new to needs_review

comment:5 Changed 5 years ago by jdemeyer

Did you check that the documentation builds properly? This looks bad (double colon but block removed):

TESTS::

- sage: exp(2,prec=100)
- doctest:...: DeprecationWarning: The prec keyword argument is deprecated. Explicitly set the precision of the input, for example exp(RealField(300)(1)), or use the prec argument to .n() for exact inputs, e.g., exp(1).n(300), instead.
- See http://trac.sagemath.org/7490 for details.
- 7.3890560989306502272304274606
-

comment:6 Changed 5 years ago by jdemeyer

  • Description modified (diff)
  • Status changed from needs_review to needs_info

Please justify why you undo the deprecation of

sage: Q.<i> = NumberField(x^2+1)
sage: gamma(i)

comment:7 Changed 5 years ago by git

  • Commit changed from 2cf6f69523d1b750ea180407d7af402739f9459f to ba38202cf55caefb032e1b4519c96b9706577004

Branch pushed to git repo; I updated commit sha1. New commits:

0f57738Merge remote-tracking branch 'origin/develop' into 16698
ba38202fix reviewer comments

comment:8 Changed 5 years ago by aapitzsch

  • Description modified (diff)
  • Status changed from needs_info to needs_review

I removed TESTS::. BTW the documentation of this function is not shown in the html reference documentation.

Replying to jdemeyer:

Please justify why you undo the deprecation of

sage: Q.<i> = NumberField(x^2+1)
sage: gamma(i)

I misinterpreted the deprecation warning. Now an exception is raised.

comment:9 Changed 5 years ago by aapitzsch

  • Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix
  • Status changed from needs_review to positive_review

Has been removed in #16023.

comment:10 Changed 5 years ago by vbraun

  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.