Opened 8 years ago

Closed 8 years ago

#16675 closed enhancement (fixed)

add function that checks if all elements of iterator are the equal

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-6.3
Component: finite state machines Keywords:
Cc: cheuberg, skropf Merged in:
Authors: Daniel Krenn Reviewers: Clemens Heuberger, Daniel Krenn
Report Upstream: N/A Work issues:
Branch: 063fb45 (Commits, GitHub, GitLab) Commit: 063fb45487df881fc8446fc94c0f3e1be76bd4e0
Dependencies: #16666, #16539 Stopgaps:

Status badges

Description

Adds a function

sage: equal([1,1])
True

to the finite state machines module (used in #16674).

Change History (10)

comment:1 Changed 8 years ago by dkrenn

  • Branch set to u/dkrenn/fsm/check_equal

comment:2 Changed 8 years ago by dkrenn

  • Authors set to Daniel Krenn
  • Commit set to 4e4801e53333adf53947085a209fa38f39b3241e
  • Status changed from new to needs_review

New commits:

95174f4Extend finite_state_machine.product_FiniteStateMachine to products of more than two machines
b080315Code cleanup in FiniteStateMachine.product_FiniteStateMachine
865b386Extend Transducer.cartesian_product to products of more than two machines
45aa114one spacing, one ``...`` in docu
390cd59added function check_equal
cc772e4added another doctest (check length of elements)
a12bf3crenamed check_equal to equal
4e4801eused equal in existing code (1 occurrence found, maybe there are more)

comment:3 Changed 8 years ago by cheuberg

  • Branch changed from u/dkrenn/fsm/check_equal to u/cheuberg/fsm/check_equal

comment:4 Changed 8 years ago by cheuberg

  • Commit changed from 4e4801e53333adf53947085a209fa38f39b3241e to 77f38046767cef9a7043c957404c2031a9af0179
  • Reviewers set to Clemens Heuberger

reviewed the patch; minor modification in docstring, please set to positive_review if you agree.


New commits:

95174f4Extend finite_state_machine.product_FiniteStateMachine to products of more than two machines
b080315Code cleanup in FiniteStateMachine.product_FiniteStateMachine
865b386Extend Transducer.cartesian_product to products of more than two machines
45aa114one spacing, one ``...`` in docu
390cd59added function check_equal
cc772e4added another doctest (check length of elements)
a12bf3crenamed check_equal to equal
4e4801eused equal in existing code (1 occurrence found, maybe there are more)
77f3804Minor rewording in docstring

comment:5 Changed 8 years ago by cheuberg

  • Dependencies set to #16666

comment:6 Changed 8 years ago by cheuberg

  • Status changed from needs_review to needs_work

does not merge cleanly with 6.3.beta5, I am preparing a modified version.

comment:7 Changed 8 years ago by git

  • Commit changed from 77f38046767cef9a7043c957404c2031a9af0179 to 063fb45487df881fc8446fc94c0f3e1be76bd4e0

Branch pushed to git repo; I updated commit sha1. New commits:

063fb45Merge remote-tracking branch 'aau/fsm/process-refuse-nondeterministic' (#16539) into t/16675/fsm/check_equal

comment:8 Changed 8 years ago by cheuberg

  • Dependencies changed from #16666 to #16666, #16539
  • Status changed from needs_work to needs_review

Merged #16539 in order to avoid merge conflict with 6.3.beta5. Please cross-review.

comment:9 Changed 8 years ago by dkrenn

  • Reviewers changed from Clemens Heuberger to Clemens Heuberger, Daniel Krenn
  • Status changed from needs_review to positive_review

comment:10 Changed 8 years ago by vbraun

  • Branch changed from u/cheuberg/fsm/check_equal to 063fb45487df881fc8446fc94c0f3e1be76bd4e0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.