Opened 5 years ago
Closed 5 years ago
#16673 closed enhancement (fixed)
Three factor construction of MOLS
Reported by:  ncohen  Owned by:  

Priority:  major  Milestone:  sage6.4 
Component:  combinatorial designs  Keywords:  
Cc:  vdelecroix, knsam, brett  Merged in:  
Authors:  Nathann Cohen  Reviewers:  Vincent Delecroix 
Report Upstream:  N/A  Work issues:  
Branch:  3fb8806 (Commits)  Commit:  3fb88062feb2c3a8e2e0baeb8102849f1b0ce93b 
Dependencies:  #16665  Stopgaps: 
Description
Yet another construction ! New designs for 648, 968, 936, 1144, 1224
and others ...
With good doc :P
Nathann
Change History (14)
comment:1 Changed 5 years ago by
 Branch set to u/ncohen/16673
 Status changed from new to needs_review
comment:2 Changed 5 years ago by
 Commit set to c26f728301a60a60264137436613c73693155871
comment:3 Changed 5 years ago by
 Commit changed from c26f728301a60a60264137436613c73693155871 to 717385e576eead6d1197f396b9c6f55788247dc6
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
717385e  trac #16673: Three factors construction of MOLS

comment:4 Changed 5 years ago by
 Component changed from PLEASE CHANGE to combinatorial designs
comment:5 Changed 5 years ago by
 Commit changed from 717385e576eead6d1197f396b9c6f55788247dc6 to a515deef3b3870433796090fbc6216fa739271f2
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
0232b73  trac #16604: OA(20,544)

e5f428d  trac #16604: Merged with 6.3.beta6

355ac2a  trac #16662: OA for n=1046,1059,2164,3992,3994

15b449c  trac #16665: New OA for n=408,600,792,856,1368,2328,...

a515dee  trac #16673: Three factors construction of MOLS

comment:6 Changed 5 years ago by
 Milestone changed from sage6.3 to sage6.4
comment:7 Changed 5 years ago by
 Commit changed from a515deef3b3870433796090fbc6216fa739271f2 to 9e144a67743f19a370735bf314ed07bf53fa3613
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
053945d  trac #16662: merge 6.3

166b525  trac #16662: doc + test

8fcaed0  trac #16662: New assertion

2a64fa2  trac #16662: find_thwart_lemma_3_5

68a2d99  trac #16662: Review

7e0480e  trac #16662: Merged with 6.4.beta0

a9b594f  trac #16662: A comment about n<N2

8615065  trac #16665: New OA for n=408,600,792,856,1368,2328,...

64b21bc  trac #16665: cosmetic

9e144a6  trac #16673: Three factors construction of MOLS

comment:8 Changed 5 years ago by
 Commit changed from 9e144a67743f19a370735bf314ed07bf53fa3613 to 9cbc23ca485c96f5c6a3f52405caec456d64db68
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
6c21904  trac #16797: correct a row/column inversion

48b6902  trac #16604: merge #16797

579e75b  trac #16604: input check + doctest

e1a83d0  trac #16604: Optional check flag

05c6915  trac #16604: Variable rename and list>set

24c4f7f  trac #16604: Merge with updated #16797

7a73e74  trac #16662: Merge with updated #16604

a71cf90  trac #16665: New OA for n=408,600,792,856,1368,2328,...

539c365  trac #16665: cosmetic

9cbc23c  trac #16673: Three factors construction of MOLS

comment:9 Changed 5 years ago by
Hello,
Why the product_with_parallel_classes
is not an independent function in orthogonal_arrays.py
?
Vincent
comment:10 Changed 5 years ago by
Because I did not think it was a good idea to expose a function like that to the user for the moment. This function is very specific, it mostly does what the oa product already does and it can lead to confusions (a guy finds this function before the other, and so uses it for the usual product).
When the OA library will be more "researchlevel" and everything why not, but for the moment there is not much to play with the OA themselves or do anything with them. We just generate those which exist.
I was somehow convinced that I had written another commit that needed this function too, but I don't seem to find it again. I hope I did not lose it anywhere or filed it in the wrong "component".
Nathann
comment:11 Changed 5 years ago by
comment:12 followup: ↓ 13 Changed 5 years ago by
Review at u/vdelecroix/16673
.
Everything is fine, if you agree with the review you can set to positive review.
Vincent
comment:13 in reply to: ↑ 12 Changed 5 years ago by
 Branch changed from u/ncohen/16673 to u/vdelecroix/16673
 Commit changed from 9cbc23ca485c96f5c6a3f52405caec456d64db68 to 3fb88062feb2c3a8e2e0baeb8102849f1b0ce93b
 Reviewers set to Vincent Delecroix
 Status changed from needs_review to positive_review
Everything is fine, if you agree with the review you can set to positive review.
Great ! Thank you very much !
I'm not a big fan of 'step=' in range but well, it's equivalent and it does not make it much harder to understand, sooo... Good to go ! :)
Nathann
New commits:
3fb8806  trac #16673: review (one line simplicaction + doc)

comment:14 Changed 5 years ago by
 Branch changed from u/vdelecroix/16673 to 3fb88062feb2c3a8e2e0baeb8102849f1b0ce93b
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
trac #16604: OA(15,896)
trac #16604: OA(16,208)
trac #16604: OA(16,176)
trac #16604: Now without copy and paste
trac #16604: OA(20,352)
trac #16604: OA(20,416)
trac #16604: OA(20,544)
trac #16662: OA for n=1046,1059,2164,3992,3994
trac #16665: New OA for n=408,600,792,856,1368,2328,...
trac #16673: Three factors construction of MOLS