Opened 8 years ago

Closed 8 years ago

#16668 closed enhancement (fixed)

Enhance FiniteStateMachine.is_Markov_chain to handle symbolic probabilities

Reported by: cheuberg Owned by:
Priority: minor Milestone: sage-6.3
Component: finite state machines Keywords: finite_state_machine, Markov chain
Cc: skropf, dkrenn Merged in:
Authors: Clemens Heuberger Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: 71246e4 (Commits, GitHub, GitLab) Commit: 71246e4429e7454d81ba32217da0a6300b032e45
Dependencies: Stopgaps:

Status badges

Description

When the probabilities of a Markov chain are variables of a polynomial ring, they may not sum up to one without additional information. Therefore, we now provide a parameter is_zero.

Change History (5)

comment:1 Changed 8 years ago by cheuberg

  • Status changed from new to needs_review

comment:2 Changed 8 years ago by dkrenn

  • Branch changed from u/cheuberg/fsm/is_markov_chain_extended to u/dkrenn/fsm/is_markov_chain_extended

comment:3 Changed 8 years ago by dkrenn

  • Commit changed from ef5ab0e906bbfc71421e3a6b6f0319e35d473fa1 to 71246e4429e7454d81ba32217da0a6300b032e45
  • Reviewers set to Daniel Krenn

Patch is fine, tests pass. Corrected a == to a = in the docu. Please cross-review and set to positive if okay for you.


New commits:

71246e4in doc of input-parameter: is_zero=None (= instead of ==)

comment:4 Changed 8 years ago by cheuberg

  • Status changed from needs_review to positive_review

fine for me.

comment:5 Changed 8 years ago by vbraun

  • Branch changed from u/dkrenn/fsm/is_markov_chain_extended to 71246e4429e7454d81ba32217da0a6300b032e45
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.