Opened 5 years ago

Closed 4 years ago

#16665 closed enhancement (fixed)

OA for n=408,600,792,856,1368,2328,...

Reported by: ncohen Owned by:
Priority: major Milestone: sage-6.4
Component: combinatorial designs Keywords:
Cc: vdelecroix Merged in:
Authors: Nathann Cohen Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 539c365 (Commits) Commit: 539c365fe6194438da47b7a7c999612ff4468ced
Dependencies: #16662 Stopgaps:

Description

Another construction from the paper used in #16662. It is recursive as always, and the find function is, this time, very easy to write :-)

Unfortunately there is only one updated value in the MOLS with v<600. The second is .... 600 :-P

Nathann

Change History (20)

comment:1 Changed 5 years ago by ncohen

  • Branch set to u/ncohen/16665
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by git

  • Commit set to 87dd885e123cae5ada5c0c73f2e131dba259de2f

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

ba6609dtrac #16604: OA for n=640, reviewer's remarks and silly mistake
c218148trac #16604: OA(15,896)
6074f4btrac #16604: OA(16,208)
35cbadctrac #16604: OA(16,176)
bfcc6f5trac #16604: Now without copy and paste
326ece4trac #16604: OA(20,352)
a621220trac #16604: OA(20,416)
54fc1e1trac #16604: OA(20,544)
6e47439trac #16662: OA for n=1046,1059,2164,3992,3994
87dd885trac #16665: New OA for n=408,600,792,856,1368,2328,...

comment:3 Changed 5 years ago by ncohen

  • Summary changed from New OA for n=408,600,792,856,1368,2328,... to OA for n=408,600,792,856,1368,2328,...

comment:4 Changed 4 years ago by git

  • Commit changed from 87dd885e123cae5ada5c0c73f2e131dba259de2f to 15b449c8622b14a7cc19ec92dd150287c2e8310a

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0232b73trac #16604: OA(20,544)
e5f428dtrac #16604: Merged with 6.3.beta6
355ac2atrac #16662: OA for n=1046,1059,2164,3992,3994
15b449ctrac #16665: New OA for n=408,600,792,856,1368,2328,...

comment:5 Changed 4 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:6 follow-up: Changed 4 years ago by vdelecroix

  • Status changed from needs_review to needs_info

Hello Nathann,

Few modifs at u/vdelecroix/16665

You prefer K.primitive_element instead of K.multiplicative_generator? I used to use the former... (not very important)

Checking that n is a prime power and then calling FiniteField(n) is redundant (not very important).

Don't you prefer raise AssertionError(msg) instead of assert False,msg?

How do you know that the following is satisfied

    # All blocks of PG should intersect 'AG_2_3' on !=2 AG_2_3.
    assert all(len(AG_2_3.intersection(B)) != 2 for B in PG)

Vincent

comment:7 in reply to: ↑ 6 ; follow-up: Changed 4 years ago by ncohen

Yo !

Few modifs at u/vdelecroix/16665

Look good !

You prefer K.primitive_element instead of K.multiplicative_generator? I used to use the former... (not very important)

I prefer the second, because it is clearer for me. But it's not my field, if I may say.

Checking that n is a prime power and then calling FiniteField(n) is redundant (not very important).

Don't you prefer raise AssertionError(msg) instead of assert False,msg?

I do.

How do you know that the following is satisfied

    # All blocks of PG should intersect 'AG_2_3' on !=2 AG_2_3.
    assert all(len(AG_2_3.intersection(B)) != 2 for B in PG)

That's what the paper claims, and the reason why 'points' is defined as it is.

Nathann

comment:8 Changed 4 years ago by ncohen

  • Branch changed from u/ncohen/16665 to u/vdelecroix/16665
  • Commit changed from 15b449c8622b14a7cc19ec92dd150287c2e8310a to afd77ce753321562f67eff40974650f9d283b48a
  • Status changed from needs_info to needs_review

New commits:

afd77cetrac #16665: cosmetic

comment:9 in reply to: ↑ 7 ; follow-up: Changed 4 years ago by vdelecroix

Replying to ncohen:

Yo !

Few modifs at u/vdelecroix/16665

Look good !

You prefer K.primitive_element instead of K.multiplicative_generator? I used to use the former... (not very important)

I prefer the second, because it is clearer for me. But it's not my field, if I may sa

Sorry: I prefer multiplicative_generator and you did use primitive_element (in orthogonal_arrays.py at line 1359 and orthogonal_arrays_recursive.py at line 1175). We seem to agree on using multiplicative_generator.

Don't you prefer raise AssertionError(msg) instead of assert False,msg?

I do.

But you wrote assert False,msg at line 1177 in orthogonal_arrays_recursive.py

How do you know that the following is satisfied

    # All blocks of PG should intersect 'AG_2_3' on !=2 AG_2_3.
    assert all(len(AG_2_3.intersection(B)) != 2 for B in PG)

That's what the paper claims, and the reason why 'points' is defined as it is.

I see.

Vincent

comment:10 in reply to: ↑ 9 Changed 4 years ago by ncohen

Yo !

Sorry: I prefer multiplicative_generator and you did use primitive_element (in orthogonal_arrays.py at line 1359 and orthogonal_arrays_recursive.py at line 1175). We seem to agree on using multiplicative_generator.

I don't mind. Change it if you like.

But you wrote assert False,msg at line 1177 in orthogonal_arrays_recursive.py

It is true. Does that invalidate my taste ? :-P

I think I saw Volker use it somewhere, and I had not thought of it. Or maybe this "False" was something else before, I don't know.

Nathann

Last edited 4 years ago by ncohen (previous) (diff)

comment:11 Changed 4 years ago by git

  • Commit changed from afd77ce753321562f67eff40974650f9d283b48a to f7cc3c199a146cf4c18db4fe1a1d275bd779b946

Branch pushed to git repo; I updated commit sha1. New commits:

f7cc3c1trac #16665: co-co-cosmetic

comment:12 Changed 4 years ago by ncohen

raise ValueError("q(={}) must be congruent to 0 or 1 mod 3")

You forgot a .format. This calls for a co-co-co-cosmetic commit.

Nathann

comment:13 Changed 4 years ago by git

  • Commit changed from f7cc3c199a146cf4c18db4fe1a1d275bd779b946 to 2eaeb09d539d65c4f7d38ea6d934e39d83fa0bbd

Branch pushed to git repo; I updated commit sha1. New commits:

2eaeb09trac #16665: coooooosmetic

comment:14 Changed 4 years ago by vdelecroix

  • Status changed from needs_review to needs_work

Once #16662 is positively reviewed, there will be some rebase...

Vincent

comment:15 Changed 4 years ago by ncohen

There is nothing I can do about that on this patch, #16662 and its dependencies must be reviewed first.

Nathann

comment:16 Changed 4 years ago by ncohen

  • Branch changed from u/vdelecroix/16665 to u/ncohen/16665
  • Commit changed from 2eaeb09d539d65c4f7d38ea6d934e39d83fa0bbd to 64b21bc54c726356c670029d22cde79bca63c76d
  • Status changed from needs_work to needs_review

Rebased ! And I merged all your "cosmetic" commits into one.

Nathann


New commits:

053945dtrac #16662: merge 6.3
166b525trac #16662: doc + test
8fcaed0trac #16662: New assertion
2a64fa2trac #16662: find_thwart_lemma_3_5
68a2d99trac #16662: Review
7e0480etrac #16662: Merged with 6.4.beta0
a9b594ftrac #16662: A comment about n<N-2
8615065trac #16665: New OA for n=408,600,792,856,1368,2328,...
64b21bctrac #16665: cosmetic

comment:17 Changed 4 years ago by vdelecroix

I thought we changed the name of _helper_function_when_n_is_prime_times_power_of_2 in #16604.

Vincent

comment:18 Changed 4 years ago by git

  • Commit changed from 64b21bc54c726356c670029d22cde79bca63c76d to 539c365fe6194438da47b7a7c999612ff4468ced

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

bff470etrac #16604: small check of dimensions
6c21904trac #16797: correct a row/column inversion
48b6902trac #16604: merge #16797
579e75btrac #16604: input check + doctest
e1a83d0trac #16604: Optional check flag
05c6915trac #16604: Variable rename and list->set
24c4f7ftrac #16604: Merge with updated #16797
7a73e74trac #16662: Merge with updated #16604
a71cf90trac #16665: New OA for n=408,600,792,856,1368,2328,...
539c365trac #16665: cosmetic

comment:19 Changed 4 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to positive_review

Doc builds. Test pass...

Vincent

comment:20 Changed 4 years ago by vbraun

  • Branch changed from u/ncohen/16665 to 539c365fe6194438da47b7a7c999612ff4468ced
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.