Opened 8 years ago
Closed 8 years ago
#16663 closed enhancement (fixed)
New common transducers all and any
Reported by: | cheuberg | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | sage-6.3 |
Component: | finite state machines | Keywords: | finite_state_machine, generators |
Cc: | skropf, dkrenn | Merged in: | |
Authors: | Clemens Heuberger, Daniel Krenn | Reviewers: | Daniel Krenn, Clemens Heuberger |
Report Upstream: | N/A | Work issues: | |
Branch: | dbddb31 (Commits, GitHub, GitLab) | Commit: | dbddb31334c9d60e9e30cdb8a689e0e41b8f88e6 |
Dependencies: | Stopgaps: |
Description
Analogously to the add
transducer, two common transducers for logical and
and or
, falling back to python's all
and any
and hence also named in that way.
Change History (5)
comment:1 Changed 8 years ago by
- Status changed from new to needs_review
comment:2 Changed 8 years ago by
- Branch changed from u/cheuberg/fsm/all-any to u/dkrenn/fsm/all-any
comment:3 Changed 8 years ago by
- Commit changed from d9c48e12ae093121eb5977c12e75cc1eee53dd54 to dbddb31334c9d60e9e30cdb8a689e0e41b8f88e6
- Reviewers set to Daniel Krenn
comment:4 Changed 8 years ago by
- Reviewers changed from Daniel Krenn to Daniel Krenn, Clemens Heuberger
- Status changed from needs_review to positive_review
cross-reviewed; setting to positive_review as instructed.
comment:5 Changed 8 years ago by
- Branch changed from u/dkrenn/fsm/all-any to dbddb31334c9d60e9e30cdb8a689e0e41b8f88e6
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Rewrote code: a function with def is now a lambda. Needs cross-review.
Apart from this, code and docs looks fine, tests pass. Give it a positive review, when positive cross-reviewed.
New commits:
make def logical_and, def logical_or inline (lambda) functions